You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/11/19 21:51:13 UTC

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

Hello Jim Apple, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11957

to look at the new patch set (#2).

Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()
......................................................................

IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

When SendTopicUpdate() returns an error, it does not set update_skipped,
so the variable is uninitialised. This means that the duration between
topic updates will depend on the uninitialised value.

Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
---
M be/src/statestore/statestore.cc
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11957/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>