You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2026/09/29 05:28:06 UTC

[PR] Spring Boot Starter and Spring Namespace support etcd, Nacos and in-memory registry centers [shardingsphere-elasticjob]

linghengqian opened a new pull request, #2548:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2548

   Fixes #2436 .
   
   Changes proposed in this pull request:
   - Spring Boot Starter and Spring Namespace support etcd, Nacos and in-memory registry centers.
   - Rename `ZookeeperProperties` to `RegistryCenterProperties`, the registry center type is selected by the new `elasticjob.reg-center.type` property.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Spring Boot Starter and Spring Namespace support etcd, Nacos and in-memory registry centers [shardingsphere-elasticjob]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2548:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2548#issuecomment-5906384221

   ## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `80.55556%` with `21 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 74.07%. Comparing base ([`a8ba448`](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/commit/a8ba448927d7e237ecece9516634a44d822a1b11?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d54b47`](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/commit/8d54b47108f3a0173edc7eda1ef1ef6bb0b434b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 98 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=registry-center%2Fprovider%2Fzookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Freg%2Fzookeeper%2FZookeeperRegistryCenter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVnaXN0cnktY2VudGVyL3Byb3ZpZGVyL3pvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL3JlZy96b29rZWVwZXIvWm9va2VlcGVyUmVnaXN0cnlDZW50ZXIuamF2YQ==) | 0.00% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...nel/internal/sharding/ShardingListenerManager.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Finternal%2Fsharding%2FShardingListenerManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9pbnRlcm5hbC9zaGFyZGluZy9TaGFyZGluZ0xpc3RlbmVyTWFuYWdlci5qYXZh) | 42.85% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...nel/internal/failover/FailoverListenerManager.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Finternal%2Ffailover%2FFailoverListenerManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9pbnRlcm5hbC9mYWlsb3Zlci9GYWlsb3Zlckxpc3RlbmVyTWFuYWdlci5qYXZh) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../elasticjob/reg/exception/RegExceptionHandler.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=registry-center%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Freg%2Fexception%2FRegExceptionHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVnaXN0cnktY2VudGVyL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvZXhjZXB0aW9uL1JlZ0V4Y2VwdGlvbkhhbmRsZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...here/elasticjob/reg/nacos/NacosRegistryCenter.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=registry-center%2Fprovider%2Fnacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Freg%2Fnacos%2FNacosRegistryCenter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVnaXN0cnktY2VudGVyL3Byb3ZpZGVyL25hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL3JlZy9uYWNvcy9OYWNvc1JlZ2lzdHJ5Q2VudGVyLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ticjob/kernel/internal/election/LeaderService.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Finternal%2Felection%2FLeaderService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9pbnRlcm5hbC9lbGVjdGlvbi9MZWFkZXJTZXJ2aWNlLmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...sticjob/kernel/internal/schedule/JobScheduler.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Finternal%2Fschedule%2FJobScheduler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9pbnRlcm5hbC9zY2hlZHVsZS9Kb2JTY2hlZHVsZXIuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...e/elasticjob/kernel/internal/schedule/LiteJob.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Finternal%2Fschedule%2FLiteJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9pbnRlcm5hbC9zY2hlZHVsZS9MaXRlSm9iLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ring/boot/reg/EtcdRegistryCenterConfiguration.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=spring%2Fboot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fspring%2Fboot%2Freg%2FEtcdRegistryCenterConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3ByaW5nL2Jvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9zcHJpbmcvYm9vdC9yZWcvRXRjZFJlZ2lzdHJ5Q2VudGVyQ29uZmlndXJhdGlvbi5qYXZh) | 90.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ing/boot/reg/NacosRegistryCenterConfiguration.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&filepath=spring%2Fboot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fspring%2Fboot%2Freg%2FNacosRegistryCenterConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3ByaW5nL2Jvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9zcHJpbmcvYm9vdC9yZWcvTmFjb3NSZWdpc3RyeUNlbnRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2548      +/-   ##
   ============================================
   - Coverage     80.10%   74.07%   -6.04%     
   - Complexity     1113     1326     +213     
   ============================================
     Files           204      226      +22     
     Lines          3821     4996    +1175     
     Branches        445      647     +202     
   ============================================
   + Hits           3061     3701     +640     
   - Misses          570      989     +419     
   - Partials        190      306     +116     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2548?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Spring Boot Starter and Spring Namespace support etcd, Nacos and in-memory registry centers [shardingsphere-elasticjob]

Posted by "terrymanu (via GitHub) via notifications" <no...@shardingsphere.apache.org>.
terrymanu merged PR #2548:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2548


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org