[GitHub] [pinot] yupeng9 commented on a change in pull request #8001: St_* function error messages + support literal transform functions

[GitBox <gi...@apache.org>]

yupeng9 commented on a change in pull request #8001:
URL: https://github.com/apache/pinot/pull/8001#discussion_r786345936



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/StEqualsFunction.java
##########
@@ -53,14 +54,22 @@ public void init(List<TransformFunction> arguments, Map<String, DataSource> data
     TransformFunction transformFunction = arguments.get(0);
     Preconditions.checkArgument(transformFunction.getResultMetadata().isSingleValue(),
         "First argument must be single-valued for transform function: %s", getName());
-    Preconditions.checkArgument(transformFunction.getResultMetadata().getDataType() == FieldSpec.DataType.BYTES,
-        "The first argument must be of bytes type");
+    Preconditions.checkArgument(transformFunction.getResultMetadata().getDataType() == FieldSpec.DataType.BYTES
+            || transformFunction instanceof LiteralTransformFunction,
+        String.format("The %s argument must be of type %s , but was %s",
+            "first",

Review comment:
       nit, you can inline `first` in the msg




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org