You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:46:56 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #20396: Add more unit test for DefaultSQLParserRuleConfigurationBuilder
strongduanmu opened a new issue, #20396:
URL: https://github.com/apache/shardingsphere/issues/20396
Hi community,
This issue is for https://github.com/apache/shardingsphere/issues/20305.
## Aim
Add more unit tests for `DefaultSQLParserRuleConfigurationBuilder` to test its public functions to improve unit test coverage.
Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere/blobs/master/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-core/src/main/java/org/apache/shardingsphere/parser/rule/builder/DefaultSQLParserRuleConfigurationBuilder.java
## Basic Qualifications
- Java
- Maven
- Junit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #20396: Add more unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #20396: Add more unit test for DefaultSQLParserRuleConfigurationBuilder
URL: https://github.com/apache/shardingsphere/issues/20396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #20396: Add more unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20396:
URL: https://github.com/apache/shardingsphere/issues/20396#issuecomment-1222086738
> https://app.codecov.io/gh/apache/shardingsphere/blobs/master/shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-core/src/main/java/org/apache/shardingsphere/parser/rule/builder/DefaultSQLParserRuleConfigurationBuilder.java
Yes, I can't open the page right now, I'll investigate why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] abhinav-koppula commented on issue #20396: Add more unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
abhinav-koppula commented on issue #20396:
URL: https://github.com/apache/shardingsphere/issues/20396#issuecomment-1263729396
@strongduanmu - I have raised a PR - https://github.com/apache/shardingsphere/pull/21291 for this. Can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on issue #20396: Add more unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #20396:
URL: https://github.com/apache/shardingsphere/issues/20396#issuecomment-1222063969
Hi @strongduanmu , the links for unit test coverage in these relevant issues are not working for me. Can you check once if they work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #20396: Add more unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20396:
URL: https://github.com/apache/shardingsphere/issues/20396#issuecomment-1222095792
@Swastyy You can try to access it from this page. https://app.codecov.io/gh/apache/shardingsphere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org