[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #14092: Refresh DruidLeaderClient cache selectively for non-200 responses

["abhishekagarwal87 (via GitHub)" <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #14092:
URL: https://github.com/apache/druid/pull/14092#discussion_r1172043286


##########
server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java:
##########
@@ -213,6 +203,9 @@ public <T, H extends FullResponseHolder<T>> H go(Request request, HttpResponseHa
         ));
 
         request = withUrl(request, redirectUrl);
+      } else if (HttpResponseStatus.SERVICE_UNAVAILABLE.equals(responseStatus)

Review Comment:
   I missed this but if there is a retry happening in response to 503/504, there will be no way to see that happening in logs. We should be logging a warning here. what do you think? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org