[jira] [Commented] (AIRFLOW-5440) Dockerfile-based static checks cannot be easily killed with ^C

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925155#comment-16925155 ] 

ASF GitHub Bot commented on AIRFLOW-5440:
-----------------------------------------

potiuk commented on pull request #6056: [AIRFLOW-5440] Static checks from docker file use dumb-init
URL: https://github.com/apache/airflow/pull/6056
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5440
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This is needed so that you can easily kill such checks with ^C
   Not doing it might cause your docker containers run for a long time
   and take precious resources.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Dockerfile-based static checks cannot be easily killed with ^C
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-5440
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5440
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.6
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> Currently when we run static checks via Docker file they might continue to run in the background because we are using Ctrl^C to kill such check. This is a known problem when you use bash script as entrypoint so we need to change it to use dumb-init instead.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)