[impala] branch master updated: IMPALA-8091: incremental improvements to NTP sync

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mikeb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 6c0ec34  IMPALA-8091: incremental improvements to NTP sync
6c0ec34 is described below

commit 6c0ec348a7ed04857a4931e7670fc81aa819b2e1
Author: Michael Brown <mi...@cloudera.com>
AuthorDate: Tue Jan 22 14:59:14 2019 -0800

    IMPALA-8091: incremental improvements to NTP sync
    
    - Warn when ntp-wait is not available.
    
    - Install ntp-perl for Redhat-based systems, which provides ntp-wait.
      Debian-based systems already have ntp-wait as provided by ntp.
    
    Change-Id: Ifc8cacf81765d132dd574993f8149231bdbb7bc6
    Reviewed-on: http://gerrit.cloudera.org:8080/12253
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 bin/bootstrap_system.sh | 2 +-
 testdata/cluster/admin  | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/bin/bootstrap_system.sh b/bin/bootstrap_system.sh
index b9c41e2..28df210 100755
--- a/bin/bootstrap_system.sh
+++ b/bin/bootstrap_system.sh
@@ -148,7 +148,7 @@ fi
 
 
 redhat sudo yum install -y curl gcc gcc-c++ git krb5-devel krb5-server krb5-workstation \
-        libevent-devel libffi-devel make ntp ntpdate openssl-devel cyrus-sasl \
+        libevent-devel libffi-devel make ntp ntpdate ntp-perl openssl-devel cyrus-sasl \
         cyrus-sasl-gssapi cyrus-sasl-devel cyrus-sasl-plain \
         python-devel python-setuptools postgresql postgresql-server \
         wget vim-common nscd cmake lzo-devel fuse-devel snappy-devel zlib-devel \
diff --git a/testdata/cluster/admin b/testdata/cluster/admin
index ef00b4e..22e7ab3 100755
--- a/testdata/cluster/admin
+++ b/testdata/cluster/admin
@@ -335,7 +335,9 @@ function start_cluster {
         NTP_CANARY=pool.ntp.org
         if ! ping -c 1 -w 5 "${NTP_CANARY}" >/dev/null 2>/dev/null; then
           echo "WARNING: cannot reach ${NTP_CANARY}; ntp sync recommended for Kudu"
-        elif ntp-wait --help >/dev/null 2>/dev/null && ! ntp-wait -v; then
+        elif ! ntp-wait --help >/dev/null 2>/dev/null; then
+          echo "WARNING: ntp-wait not installed; ntp sync recommended for Kudu"
+        elif ! ntp-wait -v; then
           echo "ntp-wait failed; cannot start kudu"
           return 1
         fi