You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/30 00:01:13 UTC
[GitHub] [arrow-datafusion] djKooks opened a new pull request #442: Change return type of 'DataFrame.collect()'
djKooks opened a new pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442
# Which issue does this PR close?
It is for following issue https://github.com/apache/arrow-datafusion/issues/47
# What changes are included in this PR?
Change return type of 'DataFrame.collect()' to 'SendableRecordBatchStream'.
Currently this is draft change, so please let me know if this change is not the one you've intended 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] djKooks edited a comment on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
djKooks edited a comment on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-879483480
@alamb sure~
But because I'm still on reviewing the project, so want to make sure I'm going in right way...
> As far as I review from now, seems it needs to fix return format of collect inside dataframe_impl. And I've fixed collect inside physical_plan because they are calling this function inside...
> Please let me know if there's any misunderstanding 🙇
=> Am I thinking correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] djKooks commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
djKooks commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-890301853
@andygrove okay. Will close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-887909992
I have created https://github.com/apache/arrow-datafusion/pull/789 to implement streaming versions of the collect methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-879356925
@djKooks do you plan to keep working on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855238255
The change in this PR looks like a good start and probably necessary, but yet, the goal is to update DataFrame::collect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] djKooks closed pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
djKooks closed pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove edited a comment on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
andygrove edited a comment on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855238255
The change in this PR looks like a good start and probably necessary, but yes, the goal is to update DataFrame::collect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] djKooks edited a comment on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
djKooks edited a comment on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855390967
@alamb @andygrove thanks for review. Will fix soon 🙏
As far as I review from now, seems it needs to fix return format of `collect` inside `dataframe_impl`. And I've fixed `collect` inside `physical_plan` because they are calling this function inside...
Please let me know if there's any misunderstanding 🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] djKooks commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
djKooks commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-879483480
@alamb sure~
But because I'm still on reviewing the project, so want to make sure I'm going in right way...
> As far as I review from now, seems it needs to fix return format of collect inside dataframe_impl. And I've fixed collect inside physical_plan because they are calling this function inside...
> Please let me know if there's any misunderstanding 🙇
=> Am I thinking correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-887735413
Sorry for the delayed response. I have been working on related areas and plan to look at this later today or tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-890324463
Thanks for prodding this along @djKooks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] djKooks commented on pull request #442: Change return type of 'DataFrame.collect()'
Posted by GitBox <gi...@apache.org>.
djKooks commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855390967
@alamb @andygrove thanks for review. Will fix soon 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org