You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/28 19:57:31 UTC
[GitHub] [geode] sabbey37 opened a new pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
sabbey37 opened a new pull request #6390:
URL: https://github.com/apache/geode/pull/6390
* wait until cache server is running before starting client session cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #6390:
URL: https://github.com/apache/geode/pull/6390#discussion_r625158122
##########
File path: extensions/geode-modules/src/main/java/org/apache/geode/modules/util/BootstrappingFunction.java
##########
@@ -97,6 +100,9 @@ protected Cache verifyCacheExists() {
}
if (cache == null) {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Creating a new cache in BootstrappingFunction");
Review comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 edited a comment on pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
Posted by GitBox <gi...@apache.org>.
sabbey37 edited a comment on pull request #6390:
URL: https://github.com/apache/geode/pull/6390#issuecomment-854883389
Closed in favor of: https://github.com/apache/geode/pull/6567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on pull request #6390:
URL: https://github.com/apache/geode/pull/6390#issuecomment-854883389
https://github.com/apache/geode/pull/6567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on pull request #6390:
URL: https://github.com/apache/geode/pull/6390#issuecomment-829624955
Feel free to suggest or add other log statements that might be helpful in debugging if the failure happens again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 closed pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
Posted by GitBox <gi...@apache.org>.
sabbey37 closed pull request #6390:
URL: https://github.com/apache/geode/pull/6390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #6390:
URL: https://github.com/apache/geode/pull/6390#discussion_r623936457
##########
File path: extensions/geode-modules/src/main/java/org/apache/geode/modules/util/BootstrappingFunction.java
##########
@@ -97,6 +100,9 @@ protected Cache verifyCacheExists() {
}
if (cache == null) {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Creating a new cache in BootstrappingFunction");
Review comment:
I'd suggest to setting it to `info` so that it's always visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #6390: GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #6390:
URL: https://github.com/apache/geode/pull/6390#discussion_r623431905
##########
File path: extensions/geode-modules/src/main/java/org/apache/geode/modules/util/BootstrappingFunction.java
##########
@@ -97,6 +100,9 @@ protected Cache verifyCacheExists() {
}
if (cache == null) {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Creating a new cache in BootstrappingFunction");
Review comment:
Is this the proper log level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org