You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/13 14:08:53 UTC
[GitHub] [shardingsphere] natehuangting opened a new pull request, #18340: add MySQLNormalReplicationCheckedDelayByDefinedSQLDatabaseDiscoveryProviderAlgorithm
natehuangting opened a new pull request, #18340:
URL: https://github.com/apache/shardingsphere/pull/18340
Fixes #18327 .
Changes proposed in this pull request:
- add MySQLNormalReplicationCheckedDelayByDefinedSQLDatabaseDiscoveryProviderAlgorithm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #18340: add MySQLNormalReplicationCheckedDelayByDefinedSQLDatabaseDiscoveryProviderAlgorithm
Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #18340:
URL: https://github.com/apache/shardingsphere/pull/18340#issuecomment-1154649299
@natehuangting Hi, i think this implement is suitable your company business, not very suitable for ss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] natehuangting closed pull request #18340: add MySQLNormalReplicationCheckedDelayByDefinedSQLDatabaseDiscoveryProviderAlgorithm
Posted by GitBox <gi...@apache.org>.
natehuangting closed pull request #18340: add MySQLNormalReplicationCheckedDelayByDefinedSQLDatabaseDiscoveryProviderAlgorithm
URL: https://github.com/apache/shardingsphere/pull/18340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18340: add MySQLNormalReplicationCheckedDelayByDefinedSQLDatabaseDiscoveryProviderAlgorithm
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18340:
URL: https://github.com/apache/shardingsphere/pull/18340#issuecomment-1154025836
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18340](https://codecov.io/gh/apache/shardingsphere/pull/18340?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c771ba4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b2692b8389c76f09d448904db08f7d6e2b5dd9c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2692b8) will **decrease** coverage by `0.05%`.
> The diff coverage is `3.63%`.
```diff
@@ Coverage Diff @@
## master #18340 +/- ##
============================================
- Coverage 59.13% 59.08% -0.06%
- Complexity 2200 2201 +1
============================================
Files 3737 3738 +1
Lines 54739 54794 +55
Branches 9303 9320 +17
============================================
+ Hits 32370 32375 +5
- Misses 19617 19667 +50
Partials 2752 2752
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...yDefinedSQLDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/18340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvTXlTUUxOb3JtYWxSZXBsaWNhdGlvbkNoZWNrZWREZWxheUJ5RGVmaW5lZFNRTERhdGFiYXNlRGlzY292ZXJ5UHJvdmlkZXJBbGdvcml0aG0uamF2YQ==) | `3.63% <3.63%> (ø)` | |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/18340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18340?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18340?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2692b8...c771ba4](https://codecov.io/gh/apache/shardingsphere/pull/18340?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org