You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/04/06 16:57:35 UTC
[GitHub] storm pull request: [STORM-745] fix storm.cmd to evaluate 'shift' ...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/506
[STORM-745] fix storm.cmd to evaluate 'shift' correctly with 'storm jar'
Please refer https://issues.apache.org/jira/browse/STORM-745 to see more details.
The problem is, shift doesn't evaluated before calling goto.
I found the hint from http://ss64.com/nt/shift.html.
```
The SHIFT command will not work within parenthesis/brackets, so place all your command line arguments in variables before running any FOR commands or other bracketed expressions. Or use the CALL syntax as explained in this forum thread.
```
Just calling goto first resolves it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-745
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/506.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #506
----
commit ad0d0d32dbfe06f8b7a40ba7205dddcfe0099a7b
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-04-06T14:53:31Z
fix storm.cmd to evaluate 'shift' correctly with 'storm jar'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-745] fix storm.cmd to evaluate 'shift' ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/506#issuecomment-90091370
Maybe storm.cmd would be something hard to maintain. Executing storm.py within storm.cmd would be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-745] fix storm.cmd to evaluate 'shift' ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/506#issuecomment-97262501
This is a regression that affects 0.9.4, and I've confirmed this patch fixes it.
I'm +1 for merging as well as applying it to the 0.9.x branch and releasing 0.9.5.
@HeartSaVioR, thanks for the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-745] fix storm.cmd to evaluate 'shift' ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/506
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-745] fix storm.cmd to evaluate 'shift' ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/506#issuecomment-99911140
Thanks for the patch @HeartSaVioR. I merged this to master, 0.9.x-branch, and 0.10.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---