You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/16 08:50:55 UTC
[GitHub] [lucene] iverase opened a new pull request #685: LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count.
iverase opened a new pull request #685:
URL: https://github.com/apache/lucene/pull/685
These query wrappers do not modify the set of matching documents so they can delegate Weight#count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase commented on a change in pull request #685: LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count.
Posted by GitBox <gi...@apache.org>.
iverase commented on a change in pull request #685:
URL: https://github.com/apache/lucene/pull/685#discussion_r808708059
##########
File path: lucene/CHANGES.txt
##########
@@ -615,6 +615,8 @@ Improvements
* LUCENE-10062: Switch taxonomy faceting to use numeric doc values for storing ordinals instead of binary doc values
with its own custom encoding. (Greg Miller)
+
+* LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count. (Ignacio Vera)
Review comment:
of course, what an oversight :)
thanks @gsmiller!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on a change in pull request #685: LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count.
Posted by GitBox <gi...@apache.org>.
gsmiller commented on a change in pull request #685:
URL: https://github.com/apache/lucene/pull/685#discussion_r808281208
##########
File path: lucene/CHANGES.txt
##########
@@ -615,6 +615,8 @@ Improvements
* LUCENE-10062: Switch taxonomy faceting to use numeric doc values for storing ordinals instead of binary doc values
with its own custom encoding. (Greg Miller)
+
+* LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count. (Ignacio Vera)
Review comment:
This should go under 9.1 right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase merged pull request #685: LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count.
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #685:
URL: https://github.com/apache/lucene/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org