Re: [PR] KAFKA-20919: Document KIP-1301 group coordinator metrics changes [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #23129:
URL: https://github.com/apache/kafka/pull/23129#discussion_r3756260990


##########
docs/operations/monitoring.md:
##########
@@ -1556,28 +1556,41 @@ The total number of groups found eligible for plugin-state deletion by the clean
 <tr>  
 <td>
 
-Classic Group Count
+Classic Group Count (deprecated)
 </td>  
 <td>
 
 kafka.server:type=GroupMetadataManager,name=NumGroups
 </td>  
 <td>
 
-Total number of Classic Groups
+Total number of Classic Groups. Deprecated: use group-count with protocol=classic instead
 </td> </tr>  
 <tr>  
 <td>
 
-Classic Group Count, per State
+Classic Group Count, per State (deprecated)
 </td>  
 <td>
 
 kafka.server:type=GroupMetadataManager,name=NumGroups[PreparingRebalance,CompletingRebalance,Empty,Stable,Dead]
 </td>  
 <td>
 
-The number of Classic Groups in each state: PreparingRebalance, CompletingRebalance, Empty, Stable, Dead
+The number of Classic Groups in each state: PreparingRebalance, CompletingRebalance, Empty, Stable, Dead. Deprecated: use classic-group-count instead
+</td> </tr>  
+<tr>  
+<td>
+
+Classic Group Count, per state
+</td>  
+<td>
+
+kafka.server:type=group-coordinator-metrics,name=classic-group-count,state=[empty|preparing_rebalance|completing_rebalance|stable|dead]

Review Comment:
   ![image](https://github.com/user-attachments/assets/29cb3e0c-54a6-4b44-b807-4c4ce901646a)
   
   It seems the naming is misaligned with the KIP
   
   (Sorry, reviewing on mobile)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org