[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #299: Daffodil 2250 cleanup runtime data vs. compile info

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #299: Daffodil 2250 cleanup runtime data vs. compile info
URL: https://github.com/apache/incubator-daffodil/pull/299#discussion_r358321108
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/Grammar.scala
 ##########
 @@ -27,14 +27,14 @@ import org.apache.daffodil.compiler.ForParser
 import org.apache.daffodil.processors.unparsers.NadaUnparser
 import org.apache.daffodil.processors.parsers.NadaParser
 
-abstract class UnaryGram(context: Term, rr: => Gram) extends NamedGram(context) {
-  private lazy val r = rr
-
-  final override lazy val gram = {
-    if (r.isEmpty) EmptyGram
-    else this
-  }
-}
+//abstract class UnaryGram(context: Term, rr: => Gram) extends NamedGram(context) {
 
 Review comment:
   If this is your only comment I need an approval so I can fix this and push it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services