You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/30 15:45:18 UTC

[GitHub] [thrift] fishy opened a new pull request #2128: THRIFT-5164: Small cleanup on the example code

fishy opened a new pull request #2128:
URL: https://github.com/apache/thrift/pull/2128


   Client: go
   
   Godoc requires at least one other exported type/function to render the
   whole example file in the example, so export
   simpleProcessorLoggingMiddleware to make the example of
   ProcessorMiddleware more helpful.
   
   Currently it's rendered in a not very helpful way:
   https://pkg.go.dev/github.com/apache/thrift@v0.13.1-0.20200430141240-5cffef964a08/lib/go/thrift?tab=doc#example-ProcessorMiddleware
   
   Compare to the client middleware example rendering:
   https://pkg.go.dev/github.com/apache/thrift@v0.13.1-0.20200430141240-5cffef964a08/lib/go/thrift?tab=doc#example-ClientMiddleware
   
   While I'm here, also update CHANGES.md to mention ClientMiddleware.
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   
   [skip ci]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621937293


   `[skip ci]` doesn't seem to work 😬 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun edited a comment on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
dcelasun edited a comment on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621939598


   > `[skip ci]` doesn't seem to work :grimacing: 
   
   I've killed the build, but there is no `[skip ci]` in the [commit body](https://github.com/apache/thrift/pull/2128/commits/2caaa9a94c4f83c6d4fac941085d229e34f150ef) :slightly_smiling_face: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621936855


   @dcelasun @pacejackson :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621978559


   Added `[skip ci]` to the commit message.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621939598


   > `[skip ci]` doesn't seem to work grimacing
   
   I've killed the build, but there is no `[skip ci]` in the [commit body](https://github.com/apache/thrift/pull/2128/commits/2caaa9a94c4f83c6d4fac941085d229e34f150ef) :slightly_smiling_face: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] pacejackson commented on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
pacejackson commented on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621978550


   👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621945928


   > The instruction says pull request, it didn't say commit message
   
   Ah, that's unfortunate. Fixed by https://github.com/apache/thrift/commit/48730688fbf00b03f0dcdf3eb44963ad894bd98e.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2128: THRIFT-5164: Small cleanup on the example code

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2128:
URL: https://github.com/apache/thrift/pull/2128#issuecomment-621944052


   The instruction says pull request, it didn't say commit message:
   
   >add [skip ci] at the end of your pull request to free up build resources.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org