You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/03/29 07:03:28 UTC
Review Request 45417: GEODE-1143: Adding GC settings for DUnit JVM
settings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45417/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Dan Smith.
Repository: geode
Description
-------
GEODE-1143: Adding GC settings for DUnit JVM settings
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java 854daa30415065ad56fd00dbb7a0a9442949b67c
Diff: https://reviews.apache.org/r/45417/diff/
Testing
-------
Thanks,
Udo Kohlmeyer
Re: Review Request 45417: GEODE-1143: Adding GC settings for DUnit JVM
settings
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45417/#review125891
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On March 29, 2016, 5:03 a.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45417/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 5:03 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1143: Adding GC settings for DUnit JVM settings
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java 854daa30415065ad56fd00dbb7a0a9442949b67c
>
> Diff: https://reviews.apache.org/r/45417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 45417: GEODE-1143: Adding GC settings for DUnit JVM
settings
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45417/#review125885
-----------------------------------------------------------
Ship it!
This won't affect the controller VM for dunit runs, just the remote VMS - vm0,vm1, etc. You could consider adding system properties to the distributedTest task in gradle/test.java.
- Dan Smith
On March 29, 2016, 5:03 a.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45417/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 5:03 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1143: Adding GC settings for DUnit JVM settings
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java 854daa30415065ad56fd00dbb7a0a9442949b67c
>
> Diff: https://reviews.apache.org/r/45417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 45417: GEODE-1143: Adding GC settings for DUnit JVM
settings
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45417/#review125927
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On March 29, 2016, 4:17 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45417/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 4:17 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1143: Adding GC settings for DUnit JVM settings
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java 854daa30415065ad56fd00dbb7a0a9442949b67c
> gradle/test.gradle 3dfefbd9da18b87f7fa752d3d45d043ee9d864f6
>
> Diff: https://reviews.apache.org/r/45417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 45417: GEODE-1143: Adding GC settings for DUnit
JVM settings
Posted by Dan Smith <ds...@pivotal.io>.
This had the unfortunate effect of dumping these GC details to the console,
I think because gradle is redirecting stdout but not stderr. Maybe we
should back out the gradle changes? I can't figure out how to get gradle to
capture the stderr as well.
-Dan
On Tue, Mar 29, 2016 at 11:59 AM, Bruce Schuchardt <bs...@pivotal.io>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45417/
>
> Ship it!
>
> Ship It!
>
>
> - Bruce Schuchardt
>
> On March 29th, 2016, 4:17 p.m. UTC, Udo Kohlmeyer wrote:
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen,
> and Dan Smith.
> By Udo Kohlmeyer.
>
> *Updated March 29, 2016, 4:17 p.m.*
> *Repository: * geode
> Description
>
> GEODE-1143: Adding GC settings for DUnit JVM settings
>
> Diffs
>
> - geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java
> (854daa30415065ad56fd00dbb7a0a9442949b67c)
> - gradle/test.gradle (3dfefbd9da18b87f7fa752d3d45d043ee9d864f6)
>
> View Diff <https://reviews.apache.org/r/45417/diff/>
>
Re: Review Request 45417: GEODE-1143: Adding GC settings for DUnit JVM
settings
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45417/#review125935
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On March 29, 2016, 4:17 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45417/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 4:17 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1143: Adding GC settings for DUnit JVM settings
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java 854daa30415065ad56fd00dbb7a0a9442949b67c
> gradle/test.gradle 3dfefbd9da18b87f7fa752d3d45d043ee9d864f6
>
> Diff: https://reviews.apache.org/r/45417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 45417: GEODE-1143: Adding GC settings for DUnit JVM
settings
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45417/
-----------------------------------------------------------
(Updated March 29, 2016, 4:17 p.m.)
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Dan Smith.
Changes
-------
Added JVM GC params into gradle/test.gradle
Repository: geode
Description
-------
GEODE-1143: Adding GC settings for DUnit JVM settings
Diffs (updated)
-----
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java 854daa30415065ad56fd00dbb7a0a9442949b67c
gradle/test.gradle 3dfefbd9da18b87f7fa752d3d45d043ee9d864f6
Diff: https://reviews.apache.org/r/45417/diff/
Testing
-------
Thanks,
Udo Kohlmeyer