You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "atharvalade (via GitHub)" <gi...@apache.org> on 2026/02/20 20:51:41 UTC
[PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
atharvalade opened a new pull request, #2792:
URL: https://github.com/apache/iggy/pull/2792
## Which issue does this PR close?
Closes #2774
## Rationale
Rust and Java already upload coverage to Codecov — Node SDK was missing.
## What changed?
Replaced `npm run test:unit` / `npm run test:e2e` in the pre-merge action with direct `node` invocations that add `--test-reporter=lcov --test-reporter-destination=../../reports/node-coverage/lcov.info`, using Node 23's native lcov support (no new dependencies). Added Codecov upload steps in `_test.yml` (pre-merge) and a `node-coverage` baseline job in `post-merge.yml`, following the same pattern as Java. Registered the `node` flag in `codecov.yml` and removed `foreign/node/**` from the ignore list.
## Local Execution
- CI-only workflow changes, no local server setup
- Pre-commit hooks ran
## AI Usage
1. Opus 4.6
2. Used to scaffold the workflow YAML following existing Java/Rust patterns
3. Verified by diffing against existing Java coverage steps and reviewing all four files
4. Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "atharvalade (via GitHub)" <gi...@apache.org>.
atharvalade commented on code in PR #2792:
URL: https://github.com/apache/iggy/pull/2792#discussion_r2854951223
##########
.github/workflows/post-merge.yml:
##########
@@ -343,6 +343,70 @@ jobs:
flags: csharp
fail_ci_if_error: false
+ node-coverage:
+ name: Node coverage baseline
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: "23"
+ cache: "npm"
+ cache-dependency-path: foreign/node/package-lock.json
+
+ - name: Setup Rust with cache
+ uses: ./.github/actions/utils/setup-rust-with-cache
+ with:
+ save-cache: "false"
+
+ - name: Install netcat
+ run: sudo apt-get update && sudo apt-get install -y netcat-openbsd
+
+ - name: Install dependencies
+ run: |
+ cd foreign/node
+ npm ci --ignore-scripts
+
+ - name: Start Iggy server
+ id: iggy
+ uses: ./.github/actions/utils/server-start
+ env:
+ IGGY_CLUSTER_ENABLED: true
+
+ - name: Run unit tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:unit
+
+ - name: Run e2e tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:e2e
Review Comment:
please check now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2792:
URL: https://github.com/apache/iggy/pull/2792#discussion_r2846037399
##########
.github/workflows/post-merge.yml:
##########
@@ -343,6 +343,70 @@ jobs:
flags: csharp
fail_ci_if_error: false
+ node-coverage:
+ name: Node coverage baseline
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: "23"
+ cache: "npm"
+ cache-dependency-path: foreign/node/package-lock.json
+
+ - name: Setup Rust with cache
+ uses: ./.github/actions/utils/setup-rust-with-cache
+ with:
+ save-cache: "false"
+
+ - name: Install netcat
+ run: sudo apt-get update && sudo apt-get install -y netcat-openbsd
+
+ - name: Install dependencies
+ run: |
+ cd foreign/node
+ npm ci --ignore-scripts
+
+ - name: Start Iggy server
+ id: iggy
+ uses: ./.github/actions/utils/server-start
+ env:
+ IGGY_CLUSTER_ENABLED: true
+
+ - name: Run unit tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:unit
+
+ - name: Run e2e tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:e2e
Review Comment:
yup, if there's no merging, then I think this is a way to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "atharvalade (via GitHub)" <gi...@apache.org>.
atharvalade commented on PR #2792:
URL: https://github.com/apache/iggy/pull/2792#issuecomment-3950174409
> The `CODECOV_TOKEN` secret is not passed to `test-node` in `pre-merge.yml`, so the upload will silently fail. Need to add `secrets: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}` to the `test-node` job.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2792:
URL: https://github.com/apache/iggy/pull/2792#issuecomment-3937471285
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2792?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 71.73%. Comparing base ([`aff29a5`](https://app.codecov.io/gh/apache/iggy/commit/aff29a544372fe5487598339830dafecb39aa14e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c699430`](https://app.codecov.io/gh/apache/iggy/commit/c6994301a7bdb2751dec0777b027b686525e07f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2792 +/- ##
============================================
+ Coverage 68.52% 71.73% +3.20%
Complexity 656 656
============================================
Files 743 852 +109
Lines 62808 72555 +9747
Branches 59221 59503 +282
============================================
+ Hits 43039 52046 +9007
- Misses 17656 18396 +740
Partials 2113 2113
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2792/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [node](https://app.codecov.io/gh/apache/iggy/pull/2792/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.26% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 109 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2792/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "atharvalade (via GitHub)" <gi...@apache.org>.
atharvalade commented on code in PR #2792:
URL: https://github.com/apache/iggy/pull/2792#discussion_r2845706405
##########
.github/workflows/post-merge.yml:
##########
@@ -343,6 +343,70 @@ jobs:
flags: csharp
fail_ci_if_error: false
+ node-coverage:
+ name: Node coverage baseline
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: "23"
+ cache: "npm"
+ cache-dependency-path: foreign/node/package-lock.json
+
+ - name: Setup Rust with cache
+ uses: ./.github/actions/utils/setup-rust-with-cache
+ with:
+ save-cache: "false"
+
+ - name: Install netcat
+ run: sudo apt-get update && sudo apt-get install -y netcat-openbsd
+
+ - name: Install dependencies
+ run: |
+ cd foreign/node
+ npm ci --ignore-scripts
+
+ - name: Start Iggy server
+ id: iggy
+ uses: ./.github/actions/utils/server-start
+ env:
+ IGGY_CLUSTER_ENABLED: true
+
+ - name: Run unit tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:unit
+
+ - name: Run e2e tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:e2e
Review Comment:
you're right, I am unaware about merging results as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2792:
URL: https://github.com/apache/iggy/pull/2792#issuecomment-3944649480
The `CODECOV_TOKEN` secret is not passed to `test-node` in `pre-merge.yml`, so the upload will silently fail. Need to add `secrets: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}` to the `test-node` job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on code in PR #2792:
URL: https://github.com/apache/iggy/pull/2792#discussion_r2845616756
##########
.github/workflows/post-merge.yml:
##########
@@ -343,6 +343,70 @@ jobs:
flags: csharp
fail_ci_if_error: false
+ node-coverage:
+ name: Node coverage baseline
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: "23"
+ cache: "npm"
+ cache-dependency-path: foreign/node/package-lock.json
+
+ - name: Setup Rust with cache
+ uses: ./.github/actions/utils/setup-rust-with-cache
+ with:
+ save-cache: "false"
+
+ - name: Install netcat
+ run: sudo apt-get update && sudo apt-get install -y netcat-openbsd
+
+ - name: Install dependencies
+ run: |
+ cd foreign/node
+ npm ci --ignore-scripts
+
+ - name: Start Iggy server
+ id: iggy
+ uses: ./.github/actions/utils/server-start
+ env:
+ IGGY_CLUSTER_ENABLED: true
+
+ - name: Run unit tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:unit
+
+ - name: Run e2e tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:e2e
Review Comment:
It looks like both `unit` and `e2e` are outputting the results into `lcov.info`. Won't the `e2e` results overwrite the `unit` results? Does this tool support merging results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Codecov coverage for Node SDK (#2774) [iggy]
Posted by "atharvalade (via GitHub)" <gi...@apache.org>.
atharvalade commented on code in PR #2792:
URL: https://github.com/apache/iggy/pull/2792#discussion_r2845752498
##########
.github/workflows/post-merge.yml:
##########
@@ -343,6 +343,70 @@ jobs:
flags: csharp
fail_ci_if_error: false
+ node-coverage:
+ name: Node coverage baseline
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: "23"
+ cache: "npm"
+ cache-dependency-path: foreign/node/package-lock.json
+
+ - name: Setup Rust with cache
+ uses: ./.github/actions/utils/setup-rust-with-cache
+ with:
+ save-cache: "false"
+
+ - name: Install netcat
+ run: sudo apt-get update && sudo apt-get install -y netcat-openbsd
+
+ - name: Install dependencies
+ run: |
+ cd foreign/node
+ npm ci --ignore-scripts
+
+ - name: Start Iggy server
+ id: iggy
+ uses: ./.github/actions/utils/server-start
+ env:
+ IGGY_CLUSTER_ENABLED: true
+
+ - name: Run unit tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:unit
+
+ - name: Run e2e tests with coverage
+ run: |
+ cd foreign/node
+ mkdir -p ../../reports/node-coverage
+ npx c8 --reporter=lcov --reports-dir=../../reports/node-coverage npm run test:e2e
Review Comment:
each step should be written to its own subdirectory. does this sound like a good plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org