You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zy-kkk (via GitHub)" <gi...@apache.org> on 2023/08/17 03:13:28 UTC
[GitHub] [doris] zy-kkk opened a new pull request, #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
zy-kkk opened a new pull request, #23080:
URL: https://github.com/apache/doris/pull/23080
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1685320282
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1682512874
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #23080:
URL: https://github.com/apache/doris/pull/23080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1681554023
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #23080:
URL: https://github.com/apache/doris/pull/23080#discussion_r1300860007
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcClient.java:
##########
@@ -229,13 +229,18 @@ public List<String> getDatabaseNameList() {
* get all tables of one database
*/
public List<String> getTablesNameList(String dbName) {
+ String currentDbName = dbName;
List<String> tablesName = Lists.newArrayList();
String[] tableTypes = getTableTypes();
if (isLowerCaseTableNames) {
- dbName = lowerDBToRealDB.get(dbName);
+ currentDbName = lowerDBToRealDB.get(dbName);
+ if (currentDbName == null) {
+ getDatabaseNameList();
+ currentDbName = lowerDBToRealDB.get(dbName);
Review Comment:
Is is still possible be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1681635250
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.21 seconds
stream load tsv: 540 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 97.3 seconds inserted 10000000 Rows, about 102K ops/s
storage size: 17162103832 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1685829097
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1687622538
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1685325747
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.29 seconds
stream load tsv: 535 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162060273 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1681725202
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1683265301
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.99 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162139587 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1685941781
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.81 seconds
stream load tsv: 540 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162246846 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1683236246
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1681777716
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.57 seconds
stream load tsv: 541 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 98.6 seconds inserted 10000000 Rows, about 101K ops/s
storage size: 17162164978 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1682591232
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.13 seconds
stream load tsv: 541 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162103406 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23080: [fix](jdbc catalog) fix adaptation to Oracle special character `/` table names
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #23080:
URL: https://github.com/apache/doris/pull/23080#issuecomment-1681613239
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org