You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/25 09:03:30 UTC

[GitHub] [incubator-nuttx] cisvanmierlo opened a new pull request #3175: boardctl: added BOARDIOC_PM_CHECKSTATE to BOARDIOC_PM_CONTROL

cisvanmierlo opened a new pull request #3175:
URL: https://github.com/apache/incubator-nuttx/pull/3175


   ## Summary
   Added boardctl BOARDIOC_PM_CHECKSTATE used in BOARDIOC_PM_CONTROL to check the recommended pm state (pm_checkstate()). 
   ## Impact
   Minimal, added a new boardctl to excisting interface.
   ## Testing
   Tested boardctl call on RDDRONE-BMS772, it worked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] cisvanmierlo commented on pull request #3175: boardctl: added BOARDIOC_PM_CHECKSTATE to BOARDIOC_PM_CONTROL

Posted by GitBox <gi...@apache.org>.
cisvanmierlo commented on pull request #3175:
URL: https://github.com/apache/incubator-nuttx/pull/3175#issuecomment-806605998


   check test failed, removed whitespace and updated code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #3175: boardctl: added BOARDIOC_PM_CHECKSTATE to BOARDIOC_PM_CONTROL

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3175:
URL: https://github.com/apache/incubator-nuttx/pull/3175#issuecomment-807597911


   I think it is good, but let give @v01d the chance to take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d merged pull request #3175: boardctl: added BOARDIOC_PM_CHECKSTATE to BOARDIOC_PM_CONTROL

Posted by GitBox <gi...@apache.org>.
v01d merged pull request #3175:
URL: https://github.com/apache/incubator-nuttx/pull/3175


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] cisvanmierlo commented on pull request #3175: boardctl: added BOARDIOC_PM_CHECKSTATE to BOARDIOC_PM_CONTROL

Posted by GitBox <gi...@apache.org>.
cisvanmierlo commented on pull request #3175:
URL: https://github.com/apache/incubator-nuttx/pull/3175#issuecomment-806482853


   @v01d @davids5 @xiaoxiang781216 Here is the other function, pm_checkstate(), as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #3175: boardctl: added BOARDIOC_PM_CHECKSTATE to BOARDIOC_PM_CONTROL

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3175:
URL: https://github.com/apache/incubator-nuttx/pull/3175#issuecomment-807599974


   I was waiting for CI to finish. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org