You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/31 21:54:39 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #1251: Revert "Pin WASM / packed SIMD tests to nightly-2022-01-17 (#1204)"
alamb opened a new pull request #1251:
URL: https://github.com/apache/arrow-rs/pull/1251
This reverts commit d68c4ae14077d60326eb57fe28133645f800d7e5.
# Which issue does this PR close?
Re https://github.com/apache/arrow-rs/issues/1198
# Rationale for this change
Upstream issue https://github.com/rust-lang/packed_simd/pull/341 seems to be resolved, so we can remove the pin and go back to using latest nightly for testing simd
# What changes are included in this PR?
Revert https://github.com/apache/arrow-rs/pull/1204
# Are there any user-facing changes?
No (CI only fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1251: Revert "Pin WASM / packed SIMD tests to nightly-2022-01-17 (#1204)"
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1251:
URL: https://github.com/apache/arrow-rs/pull/1251#issuecomment-1026834443
Looks good. I saw the [fix was announced on twitter](https://twitter.com/workingjubilee/status/1487677440256188416)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1251: Revert "Pin WASM / packed SIMD tests to nightly-2022-01-17 (#1204)"
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1251:
URL: https://github.com/apache/arrow-rs/pull/1251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1251: Revert "Pin WASM / packed SIMD tests to nightly-2022-01-17 (#1204)"
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1251:
URL: https://github.com/apache/arrow-rs/pull/1251#issuecomment-1026260366
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1251?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1251](https://codecov.io/gh/apache/arrow-rs/pull/1251?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae5dec3) into [master](https://codecov.io/gh/apache/arrow-rs/commit/aac1844ce707e3744595472b0357c101a91b5749?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac1844) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ae5dec3 differs from pull request most recent head dab9385. Consider uploading reports for the commit dab9385 to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/1251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1251 +/- ##
=======================================
Coverage 82.96% 82.96%
=======================================
Files 178 178
Lines 51547 51547
=======================================
+ Hits 42765 42767 +2
+ Misses 8782 8780 -2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1251/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `84.77% <0.00%> (+0.12%)` | :arrow_up: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1251/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1251?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1251?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aac1844...dab9385](https://codecov.io/gh/apache/arrow-rs/pull/1251?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org