You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2024/12/18 00:11:29 UTC

(royale-compiler) 01/02: linter: ignore CannotResolveConfigExpressionProblem, like formatter does

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git

commit 8f05fa88c0afd34f45f07a00fcd573b9bfaeee84
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Tue Dec 17 14:34:01 2024 -0800

    linter: ignore CannotResolveConfigExpressionProblem, like formatter does
    
    We don't need to resolve config expressions for the linter
---
 linter/src/main/java/org/apache/royale/linter/ASLinter.java | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/linter/src/main/java/org/apache/royale/linter/ASLinter.java b/linter/src/main/java/org/apache/royale/linter/ASLinter.java
index 8b453de8b..d54f5518a 100644
--- a/linter/src/main/java/org/apache/royale/linter/ASLinter.java
+++ b/linter/src/main/java/org/apache/royale/linter/ASLinter.java
@@ -39,6 +39,7 @@ import org.apache.royale.compiler.internal.semantics.PostProcessStep;
 import org.apache.royale.compiler.internal.tree.as.FileNode;
 import org.apache.royale.compiler.internal.workspaces.Workspace;
 import org.apache.royale.compiler.parsing.IASToken;
+import org.apache.royale.compiler.problems.CannotResolveConfigExpressionProblem;
 import org.apache.royale.compiler.problems.ICompilerProblem;
 import org.apache.royale.compiler.problems.UnexpectedExceptionProblem;
 import org.apache.royale.compiler.tree.ASTNodeID;
@@ -117,7 +118,14 @@ public class ASLinter extends BaseLinter {
 			}
 
 			if (parser.getSyntaxProblems().size() > 0) {
-				fileProblems.addAll(parser.getSyntaxProblems());
+				for (ICompilerProblem problem : parser.getSyntaxProblems()) {
+					if (problem instanceof CannotResolveConfigExpressionProblem) {
+						// it's okay if config constants aren't resolved
+						// we don't need to resolve anything
+						continue;
+					}
+					fileProblems.add(problem);
+				}
 			}
 
 			if (!settings.ignoreProblems && hasErrors(fileProblems)) {