You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 11:55:34 UTC

[GitHub] [flink] wuchong commented on a change in pull request #10784: [FLINK-15494] Fix time field index wrong in LogicalWindowAggregateRul…

wuchong commented on a change in pull request #10784: [FLINK-15494] Fix time field index wrong in LogicalWindowAggregateRul…
URL: https://github.com/apache/flink/pull/10784#discussion_r365759754
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
 ##########
 @@ -100,6 +100,35 @@ class WindowAggregateITCase(mode: StateBackendMode)
     assertEquals(expected.sorted, sink.getAppendResults.sorted)
   }
 
+  @Test
+  def testDoubleTumbleWindow(): Unit = {
 
 Review comment:
   Could you add a similar nested window agg test for batch? 
   You can place it in `org.apache.flink.table.planner.runtime.batch.sql.agg.WindowAggregateITCase`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services