You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Smith-Cruise (via GitHub)" <gi...@apache.org> on 2025/10/21 14:52:01 UTC
[PR] [C++] Parquet MakeColumnStats should use user-provided memory pool [arrow]
Smith-Cruise opened a new pull request, #47894:
URL: https://github.com/apache/arrow/pull/47894
### Rationale for this change
Looks like we forgot to pass the user-provided memory pool in `ColumnChunkMetaData::statistics`
### What changes are included in this PR?
Pass the memory pool from ReaderProperties
### Are these changes tested?
PASSED
### Are there any user-facing changes?
NO
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Parquet MakeColumnStats should use user-provided memory pool [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3427379424
While the fix is trivial, this does not seem to be a "minor" issue according to https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#minor-fixes, can you open an GH issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47905: [C++] Parquet MakeColumnStats should use user-provided memory pool [arrow]
Posted by "Smith-Cruise (via GitHub)" <gi...@apache.org>.
Smith-Cruise commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3430420768
> While the fix is trivial, this does not seem to be a "minor" issue according to https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#minor-fixes, can you open an GH issue?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47905: [C++][Parquet] MakeColumnStats should use user-provided memory pool [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #47894:
URL: https://github.com/apache/arrow/pull/47894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47894: [C++] Parquet MakeColumnStats should use user-provided memory pool [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3427125324
:warning: GitHub issue #47894 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47905: [C++] Parquet MakeColumnStats should use user-provided memory pool [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3430419626
:warning: GitHub issue #47905 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47905: [C++][Parquet] MakeColumnStats should use user-provided memory pool [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3431483085
@Smith-Cruise That failure is unrelated, we can ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-47894]: [C++] Parquet MakeColumnStats should use user-provided memory pool [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3427114911
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47905: [C++][Parquet] MakeColumnStats should use user-provided memory pool [arrow]
Posted by "Smith-Cruise (via GitHub)" <gi...@apache.org>.
Smith-Cruise commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3431338678
> Thanks @Smith-Cruise!
Looks like one of the CI runs failed, can you help me re-run it? It looks irrelevant to my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47905: [C++][Parquet] MakeColumnStats should use user-provided memory pool [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47894:
URL: https://github.com/apache/arrow/pull/47894#issuecomment-3434088664
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 03896451c69658105e857ae7103e5081bbaa9bd6.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `amd64-m5-4xlarge-linux` at [2025-10-22 11:27:34Z](https://conbench.ursa.dev/compare/runs/3982c601e2f8409ca90e488a4a2485b0...01abb7ace44841758bfbf088479d4b30/)
- [`partitioned-dataset-filter` (R) with dataset=dataset-taxi-parquet, language=R, query=vignette](https://conbench.ursa.dev/compare/benchmarks/068f8f02d342772f80001b8f3e40e999...068f8eead8f276458000f1be7abe3603)
The [full Conbench report](https://github.com/apache/arrow/runs/53420514710) has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org