You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/08/23 02:47:00 UTC

[jira] [Commented] (IMPALA-7460) update paramiko and fabric

    [ https://issues.apache.org/jira/browse/IMPALA-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589616#comment-16589616 ] 

ASF subversion and git services commented on IMPALA-7460:
---------------------------------------------------------

Commit 971cf179f674b312cd133397fe74ee8c5f29a215 in impala's branch refs/heads/master from [~leto]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=971cf17 ]

IMPALA-7460 part 1: require user to install Paramiko and Fabric

- Remove Fabric and Paramiko as requirements. They aren't needed by
  anything in buildall.sh.
- Add a means to install into the impala-python virtual environment by hand.
  impala-pip is fine for this.
- Add another requirements file for extended testing. The dependency
  situation is messy and untangling that out of impala-python and into
  lib/python should be out of the scope of IMPALA-7460.
- Update core tests, which cover real regressions that have happened in
  the past, to run against locations that don't require a Paramiko
  import. This moves some logic out of concurrent_select.py into a
  thinner module.
- Insulate ssh_util from globally-scoped import so that it only imports
  when needed.

Testing:
- This works in my development environment.
- This works in my downstream stress and query gen environments.
- This works when doing a full data load.
- Impala still builds on a variety of OSs.

Todo:
- A subsequent review will update the versions.

Change-Id: Ibf9010a0387b52c95b7bda5d1d4606eba1008b65
Reviewed-on: http://gerrit.cloudera.org:8080/11264
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> update paramiko and fabric
> --------------------------
>
>                 Key: IMPALA-7460
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7460
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 3.1.0
>            Reporter: Michael Brown
>            Assignee: Michael Brown
>            Priority: Critical
>
> Paramiko and Fabric are in our development environment, pretty old, and should be updated. But they aren't used in the product or regular buildall.sh-driven tests, at least not to my knowledge. Let's figure out a way to update them in dev environments but prefer to get them out of the complicated infra/python/deps/*.txt requirements stages. This relaxes the breadth of platforms on which we must support these libs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org