You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Au-Miner (via GitHub)" <gi...@apache.org> on 2024/12/09 12:51:50 UTC
[PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]
Au-Miner opened a new pull request, #25765:
URL: https://github.com/apache/flink/pull/25765
## What is the purpose of the change
Introduce TemporalProcessTimeJoinOperator in TemporalJoin with async state api.
## Brief change log
- *Introduce TemporalProcessTimeJoinOperator in TemporalJoin with async state api.*
- *Add ITs and HarnessTests*
## Verifying this change
Existent tests and new added tests can verify this change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]
Posted by "jnh5y (via GitHub)" <gi...@apache.org>.
jnh5y commented on code in PR #25765:
URL: https://github.com/apache/flink/pull/25765#discussion_r1878359281
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java:
##########
@@ -276,12 +278,21 @@ private TwoInputStreamOperator<RowData, RowData, RowData> createJoinOperator(
isLeftOuterJoin);
} else {
if (isTemporalFunctionJoin) {
- return new TemporalProcessTimeJoinOperator(
- InternalTypeInfo.of(rightInputType),
- generatedJoinCondition,
- minRetentionTime,
- maxRetentionTime,
- isLeftOuterJoin);
+ if (config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
Review Comment:
As a heads up, changes like this should update consumedOptions for the JSON serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25765:
URL: https://github.com/apache/flink/pull/25765#issuecomment-2527850587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "200f52ff00af3e6eed2f45e5b5e4e27b2f2c3059",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "200f52ff00af3e6eed2f45e5b5e4e27b2f2c3059",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 200f52ff00af3e6eed2f45e5b5e4e27b2f2c3059 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]
Posted by "Au-Miner (via GitHub)" <gi...@apache.org>.
Au-Miner closed pull request #25765: [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API
URL: https://github.com/apache/flink/pull/25765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]
Posted by "Au-Miner (via GitHub)" <gi...@apache.org>.
Au-Miner commented on code in PR #25765:
URL: https://github.com/apache/flink/pull/25765#discussion_r1879682939
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java:
##########
@@ -276,12 +278,21 @@ private TwoInputStreamOperator<RowData, RowData, RowData> createJoinOperator(
isLeftOuterJoin);
} else {
if (isTemporalFunctionJoin) {
- return new TemporalProcessTimeJoinOperator(
- InternalTypeInfo.of(rightInputType),
- generatedJoinCondition,
- minRetentionTime,
- maxRetentionTime,
- isLeftOuterJoin);
+ if (config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
Review Comment:
Thanks for review. Due to a change in the warehouse path, the PR has been resubmitted https://github.com/apache/flink/pull/25777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36851][table] Introduce TemporalProcessTimeJoinOperator in TemporalJoin with Async State API [flink]
Posted by "Au-Miner (via GitHub)" <gi...@apache.org>.
Au-Miner commented on PR #25765:
URL: https://github.com/apache/flink/pull/25765#issuecomment-2535284432
Thanks for review. Due to a change in the warehouse path, the PR has been resubmitted https://github.com/apache/flink/pull/25777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org