[jira] [Commented] (MESOS-5384) Improve error message for missing resources file

["Kris Paprocki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15461069#comment-15461069 ] 

Kris Paprocki commented on MESOS-5384:
--------------------------------------

Actually, documentation/code says:

"To use JSON, pass a JSON-formatted string or use --resources=filepath to specify the resources via a file containing a JSON-formatted string. 'filepath' can be of the form file:///path/to/file or /path/to/file."

Is the /path/to/file generally allowed/deprecated/not-supported?

Additionally, in the code we give "deprecated" warning when the path is specified without 'file://', however only when parsing JSON::Array and JSON::Object (see 3rdparty/stout/include/stout/flags/parse.hpp). 
Wouldn't it make sense to make this as a generic rule when reading from /path/to/file? 

Also, if we set a generic rule, I propose to move reading the content of the /path/to/file from 3rdparty/stout/include/stout/flags/parse.hpp to 3rdparty/stout/include/stout/flags/fetch.hpp. It was a little bit surprising to find another reading hidden in parse.hpp file.

> Improve error message for missing resources file
> ------------------------------------------------
>
>                 Key: MESOS-5384
>                 URL: https://issues.apache.org/jira/browse/MESOS-5384
>             Project: Mesos
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 0.28.1
>         Environment: Centos 7
>            Reporter: John Yost
>            Assignee: Kris Paprocki
>            Priority: Minor
>              Labels: easyfix, newbie
>
> Attempting to specify resources file via --resources=/etc/mesos-slave/small-slave-config.json threw the following error:
> Failed to determine slave resources: Bad value for resources, missing or extra ':' in /etc/mesos-slave/small-slave-config.json
> I confirmed I had valid JSON: 
> [
>   {
>     "name": "cpus",
>     "type": "SCALAR",
>     "scalar": {
>       "value": 0.5
>     }
>   },
>   {
>     "name": "mem",
>     "type": "SCALAR",
>     "scalar": {
>       "value": 512
>     }
>   }
> ]
> In actuality, I misread to docs with my file pattern. Once I changed to resources=file:///etc/mesos-slave/small-slave-config.json the mesos slave started up fine. Just need a missing file check and corresponding error message to fix this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)