[jira] [Commented] (JCRVLT-415) jackrabbit-emptyelements validator reports error for nested folders

["Dominik Süß (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363708#comment-17363708 ] 

Dominik Süß commented on JCRVLT-415:
------------------------------------

[~kwin] - the potential issue reported in JCRVLT-417 actually stems from this one. Reverting this commit eliminate the problems all together. It looks like due to this change even with a mode=merge and non-matching include filter this switches the root node of a filter to nt:folder (as there is no .content.xml for this node that is not intended to be created on its own) which makes the creation of the child nodes fail (concrete case is a filter for /home/groups with mode=merge and an include pattern matching multiple concrete groups to be imported)

The checks when this logic should apply is apparently broken as with mode=merge no change  to existing nodes should happen at all.

> jackrabbit-emptyelements validator reports error for nested folders
> -------------------------------------------------------------------
>
>                 Key: JCRVLT-415
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-415
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: vlt
>    Affects Versions: 3.4.2
>            Reporter: Csaba Varga
>            Assignee: Konrad Windszus
>            Priority: Minor
>             Fix For: 3.4.4, package-maven-plugin-1.1.2
>
>         Attachments: test.zip, test2.zip
>
>
> When an nt:folder node is present under an orderable node, the "jackrabbit-emptyelements" validator will report an issue (breaking the build with the default settings of the package Maven plugin). I believe this shouldn't be reported as an issue because the AEM Package Manager can generate packages like this. For example, see the attached test.zip file, which was exported on an out-of-the-box AEM 6.5 instance with dummy nodes.
> To reproduce, save test.zip somewhere, then invoke the validation Maven goal in the command like like this:
> {{mvn org.apache.jackrabbit:filevault-package-maven-plugin:validate-package -Dvault.packageToValidate=test.zip}}
> test.zip contains the following very simple node hierarchy:
> {{/}}
>  {{  test (nt:unstructured)}}
>  {{    foo (nt:folder)}}
>  {{      bar (nt:folder)}}
>  {{        baz (sling:OrderedFolder)}}
> The error I'm getting is:
> {{[ERROR] ValidationViolation: "jackrabbit-emptyelements: Found empty nodes: '/test/foo' (in 'test\.content.xml') (used for ordering only) which are included in the filter with mode=merge. Rather use the according include/exclude patterns."}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)