You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "770120041 (via GitHub)" <gi...@apache.org> on 2026/03/09 00:32:27 UTC

[PR] Spark: Fix ThreadLocal capacity leak in CommitMetadata [iceberg]

770120041 opened a new pull request, #15547:
URL: https://github.com/apache/iceberg/pull/15547

   ## Summary
   Fix ThreadLocal memory leak in `CommitMetadata` by replacing `COMMIT_PROPERTIES.set(ImmutableMap.of())` with `COMMIT_PROPERTIES.remove()` in the finally block.
   
   Using `set()` with an empty map keeps the entry in the ThreadLocal map, causing a capacity leak over time. `remove()` properly cleans up the entry from the thread's ThreadLocalMap.
   
   Fixes #15284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Spark: Fix ThreadLocal capacity leak in CommitMetadata [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #15547:
URL: https://github.com/apache/iceberg/pull/15547#issuecomment-4028873699

   This PR appears to be generated and submitted by AI without human review. Closing for now. If you'd like to resubmit, please follow our AI contribution guidelines: https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Spark: Fix ThreadLocal capacity leak in CommitMetadata [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao closed pull request #15547: Spark: Fix ThreadLocal capacity leak in CommitMetadata
URL: https://github.com/apache/iceberg/pull/15547


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org