You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ajantha-bhat <gi...@git.apache.org> on 2018/09/04 08:17:43 UTC
[GitHub] carbondata pull request #2690: [HOTFIX] support long string columns with spa...
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2690
[HOTFIX] support long string columns with spark FileFormat
**problem:** Exception if we try long string column for Spark file format
**Solution:** For Varchar data type respective spark data type was selected, hence the exception.
Spark don't have limit for string data type. so map varchar to string type.
Tested with more than 32K length string and added a UT
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? NA
- [ ] Any backward compatibility impacted? NA
- [ ] Document update required? NA
- [ ] Testing done.
Added UT
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajantha-bhat/carbondata master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2690
----
commit 9a3c8045fdf6540d413601bdb9443f72141a8c87
Author: ajantha-bhat <aj...@...>
Date: 2018-09-04T08:07:09Z
support long string columns with spark FileFormat
----
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2690
LGTM
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/339/
---
[GitHub] carbondata issue #2690: [WIP] support long string columns with spark FileFor...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8369/
---
[GitHub] carbondata issue #2690: [CARBONDATA-2922] support long string columns with s...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2690
@ravipesala : PR is ready, please review
---
[GitHub] carbondata issue #2690: [WIP] support long string columns with spark FileFor...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/299/
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8413/
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/342/
---
[GitHub] carbondata issue #2690: [WIP] support long string columns with spark FileFor...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/131/
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8286/
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/4/
---
[GitHub] carbondata pull request #2690: [CARBONDATA-2922] support long string columns...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2690
---
[GitHub] carbondata issue #2690: [WIP] support long string columns with spark FileFor...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2690
@ravipesala : As per the discussion, sdk and spark file format uses varchar instead of string now . so, code changed again. please review again.
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8410/
---
[GitHub] carbondata issue #2690: [CARBONDATA-2922] support long string columns with s...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2690
LGTM
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2690
@ravipesala : please reveiw
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/171/
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/174/
---
[GitHub] carbondata issue #2690: [HOTFIX] support long string columns with spark File...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2690
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/215/
---