You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "trueleo (via GitHub)" <gi...@apache.org> on 2023/04/13 11:16:23 UTC

[GitHub] [arrow-rs] trueleo opened a new issue, #4078: object_store: Incorrect parsing of https scheme S3 url

trueleo opened a new issue, #4078:
URL: https://github.com/apache/arrow-rs/issues/4078

   **Description**
   Currently, the S3 bucket URL parsing in for AWS [here](https://docs.rs/object_store/latest/object_store/aws/struct.AmazonS3Builder.html#method.with_url)  is mistakenly parsing the bucket out of URL `https://s3.bucket.amazonaws.com`. However, this URL does not represent a valid S3 bucket URL format. The correct format should be `https://s3.region.amazonaws.com/bucket` for Path style as mentioned in AWS user guide [here](https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-bucket-intro.html)
   
   **Expected behavior**
   The `parse_url` method on builder should correctly parse the S3 bucket URL and set region and bucket accordingly.
   
   
   
   **Additional context**
   [Invalid URL in Test](https://docs.rs/object_store/latest/src/object_store/aws/mod.rs.html#1414)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on issue #4078: object_store: Incorrect parsing of https Path Style S3 url

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #4078:
URL: https://github.com/apache/arrow-rs/issues/4078#issuecomment-1517889525

   `label_issue.py` automatically added labels {'object-store'} from #4082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] object_store: Incorrect parsing of https Path Style S3 url [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #4078:
URL: https://github.com/apache/arrow-rs/issues/4078#issuecomment-2741684783

   Migrating from arrow-rs issue [#4078](https://github.com/apache/arrow-rs/issues/4078)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on issue #4078: object_store: Incorrect parsing of https scheme S3 url

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #4078:
URL: https://github.com/apache/arrow-rs/issues/4078#issuecomment-1506818534

   I agree that the logic doesn't appear to be consistent with the docs you linked and would support changing it to match
   
   This code was originally contributed in https://github.com/apache/arrow-rs/pull/3327/files#diff-463799e28d6cd175bcf4dd2b296385646ebed96271da65b05a02ab133d31c82cR1028 so tagging @roeap for context
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #4078: object_store: Incorrect parsing of https Path Style S3 url

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #4078: object_store: Incorrect parsing of https Path Style S3 url
URL: https://github.com/apache/arrow-rs/issues/4078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] roeap commented on issue #4078: object_store: Incorrect parsing of https Path Style S3 url

Posted by "roeap (via GitHub)" <gi...@apache.org>.
roeap commented on issue #4078:
URL: https://github.com/apache/arrow-rs/issues/4078#issuecomment-1506827909

   Yes, there seems to be a bug.
   
   https://github.com/apache/arrow-rs/blob/f14a6787cae77d9eb7d44a8cbb71d9fcc9f8365a/object_store/src/aws/mod.rs#L811-L821
   
   In the first match we should be assigning the region, nut the bucket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org