[jira] [Commented] (BEAM-12497) BigQueryIO should return successfully inserted rows

["Lily B Liu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-12497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447433#comment-17447433 ] 

Lily B Liu commented on BEAM-12497:
-----------------------------------

I tried this feature combined with Dataflow template (pubsub to BigQuery).

However, the writeResult.getSuccessfulInserts() returns empty PCollection. I debugged the PR above: [https://github.com/apache/beam/pull/15013|http://example.com/]
{code:java}
 return batchViaStateful        
? input.apply(new ViaStateful())        
: input.apply(new ViaBundleFinalization());{code}
Only when ViaStateful, below code was added:

{code:java}
      for (ValueInSingleWindow<TableRow> row : successfulInserts) {
        out.get(SUCCESSFUL_ROWS_TAG).output(row.getValue());
      }
{code}

Function finishBundle only contains failedInserts settings.

Shouldn't successfulInserts be returned on both conditions?

> BigQueryIO should return successfully inserted rows
> ---------------------------------------------------
>
>                 Key: BEAM-12497
>                 URL: https://issues.apache.org/jira/browse/BEAM-12497
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>            Reporter: Pablo Estrada
>            Assignee: Pablo Estrada
>            Priority: P2
>             Fix For: 2.32.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> As part of a CDC use case, we want to be able to receive rows AFTER they've been successfully inserted.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)