You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2024/08/16 17:25:31 UTC
[PR] Fix whats-new links and remove redundant timeout [trafficserver]
bneradt opened a new pull request, #11707:
URL: https://github.com/apache/trafficserver/pull/11707
whats-new has malformed link references to non-existent links. This fixes that. Also connect_attempts_timeout changes are referenced twice in upgrading in a way that doesn't seem helpful: we say first that we removed them, then in a separate bullet we say that they are removed from default config. The latter is implied by the former.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix whats-new links and remove redundant timeout [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #11707:
URL: https://github.com/apache/trafficserver/pull/11707#issuecomment-2293925957
Yeah, that's what implied. If we remove either of them I'd remove the one in whats-new.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix whats-new links and remove redundant timeout [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #11707:
URL: https://github.com/apache/trafficserver/pull/11707#issuecomment-2293921028
> The line between upgrading and whats-new is getting blurry. I thought whats-new only have things purely new (i.e. upgrading without reading whats-new doesn't harm anything).
Yeah, I was just fixing the formatting there. Want me to remove that section all together? It's already covered in upgrading. It seems to me that it doesn't belong in "whats new".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix whats-new links and remove redundant timeout [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #11707:
URL: https://github.com/apache/trafficserver/pull/11707#issuecomment-2293980837
> Yeah, that's what implied. If we remove either of them I'd remove the one in whats-new.
Gotcha. Thanks for the thought. Updated with the removal of the section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix whats-new links and remove redundant timeout [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #11707:
URL: https://github.com/apache/trafficserver/pull/11707#issuecomment-2293891070
The line between upgrading and whats-new is getting blurry. I thought whats-new only have things purely new (i.e. upgrading without reading whats-new doesn't harm anything).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix whats-new links and remove redundant timeout [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #11707:
URL: https://github.com/apache/trafficserver/pull/11707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org