[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2277: HDDS-5264. SCM should send token for CloseContainer command

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #2277:
URL: https://github.com/apache/ozone/pull/2277#discussion_r640972808



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/CloseContainerEventHandler.java
##########
@@ -99,6 +101,14 @@ public void onMessage(ContainerID containerID, EventPublisher publisher) {
     }
   }
 
+  private String getContainerToken(ContainerID containerID) {
+    StorageContainerManager scm = scmContext.getScm();
+    return scm != null
+        ? scm.getContainerTokenGenerator()
+            .generateEncodedToken(getClass().getSimpleName(), containerID)

Review comment:
       should we pass meaningful name here instead of the class name as user for the container token?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org