You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Peter Schuller (Created) (JIRA)" <ji...@apache.org> on 2011/12/27 01:42:31 UTC
[jira] [Created] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
ship with -XX:+ExplicitGCInvokesConcurrent by default
-----------------------------------------------------
Key: CASSANDRA-3675
URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
Project: Cassandra
Issue Type: Improvement
Reporter: Peter Schuller
Assignee: Peter Schuller
Priority: Minor
It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Chris Goffinet (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202006#comment-13202006 ]
Chris Goffinet edited comment on CASSANDRA-3675 at 2/7/12 2:23 AM:
-------------------------------------------------------------------
I am going to revert this commit. I reviewed it, and posted a note in IRC but that looks to be missed. We had been running this in prod on 0.8 for sometime, so I felt it was safe.
was (Author: lenn0x):
I am going to revert this commit.
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Chris Goffinet (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-3675:
--------------------------------------
Fix Version/s: 1.1
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201023#comment-13201023 ]
Jonathan Ellis commented on CASSANDRA-3675:
-------------------------------------------
Of course the downside is that CMS is not compacting. Given that fragmentation has been an issue I have reservations about changing this behavior from the default, expected behavior. It seems to me that if people are in the "let's see what my working set is" testing phase, a STW collection is not going to cause big problems.
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Chris Goffinet (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-3675:
--------------------------------------
Reviewer: lenn0x
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Chris Goffinet (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet reopened CASSANDRA-3675:
---------------------------------------
I am going to revert this commit.
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201024#comment-13201024 ]
Peter Schuller commented on CASSANDRA-3675:
-------------------------------------------
I don't understand. If you have fragmentation problems, you're going to take full gc:s that do compaction anyway when you have a promotion failure so it's not like you're not going to get your heap compacted.
Are you saying people are expected to be in the category of people that want to pre-emptively run full compacting GC:s, yet want to do so ad-hoc without changing GC settings and scripting around it?
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Chris Goffinet (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet resolved CASSANDRA-3675.
---------------------------------------
Resolution: Won't Fix
Reverted
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201463#comment-13201463 ]
Jonathan Ellis commented on CASSANDRA-3675:
-------------------------------------------
Looks like this got ninja committed during the discussion. I'm -0, for the record: people who need this can easily add it; for the majority who don't, I'd rather preserve the default behavior.
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Peter Schuller (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Schuller updated CASSANDRA-3675:
--------------------------------------
Attachment: CASSANDRA-3675-trunk.txt
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Chris Goffinet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202007#comment-13202007 ]
Chris Goffinet commented on CASSANDRA-3675:
-------------------------------------------
For the record, I still think this is a sane default.
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3675) ship with
-XX:+ExplicitGCInvokesConcurrent by default
Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201025#comment-13201025 ]
Peter Schuller commented on CASSANDRA-3675:
-------------------------------------------
Btw I have been in a position several times of a production cluster having some kind of issue, and wanting to know what the live set is in a situation where I don't want to trigger full gcs. It's also a way to trigger CMS earlier without having to restart a node (temporarily).
> ship with -XX:+ExplicitGCInvokesConcurrent by default
> -----------------------------------------------------
>
> Key: CASSANDRA-3675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3675
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-3675-trunk.txt
>
>
> It's so much easier if you can safely tell people to trigger a full GC to discover their live set (see CASSANDRA-3574), instead of explaining the behavior of CMS and what the memory usage graph looks like etc etc. Shipping with {{-XX:+ExplicitGCInvokesConcurrent}} means this is by default safe.
> For people that have special needs like some kind of rolling compacting GC with disablegossip, they are special enough that they can just change the VM options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira