You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/22 19:56:40 UTC
[GitHub] [incubator-mxnet] kpuatamazon opened a new pull request #19408: [LICENSE] Change intgemm to a submodule instead of fetch.
kpuatamazon opened a new pull request #19408:
URL: https://github.com/apache/incubator-mxnet/pull/19408
## Description ##
This resolves the issue that `LICENSE` referred to `3rdparty/intgemm/LICENSE` which was not present in the source because it was downloaded:
https://lists.apache.org/thread.html/r669576b6506f67ea96e9b1bd385b04f59c4e6e7fa1b13a6dc0abc7d9%40%3Cgeneral.incubator.apache.org%3E
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Remove fetch from `CMakeLists.txt`
- [x] Add submodule in `3rdparty`
- [x] Mention catch in top-level LICENSE
- [x] Exclude intgemm from header license checks
### Note ###
Sibling #19406 addresses v1.8.x and ## Description ##
This resolves the issue that `LICENSE` referred to `3rdparty/intgemm/LICENSE` which was not present in the source because it was downloaded:
https://lists.apache.org/thread.html/r669576b6506f67ea96e9b1bd385b04f59c4e6e7fa1b13a6dc0abc7d9%40%3Cgeneral.incubator.apache.org%3E
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Remove fetch from `CMakeLists.txt`
- [x] Add submodule in `3rdparty`
- [x] Mention catch in top-level LICENSE
- [x] Exclude intgemm from header license checks
### Note ###
Sibling #19406 addresses v1.8.x. #19407 addresses v1.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19408: [LICENSE] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19408:
URL: https://github.com/apache/incubator-mxnet/pull/19408#issuecomment-714729127
None of the jobs entered are supported.
Jobs entered by user: [greetings]
CI supported Jobs: [unix-cpu, centos-gpu, sanity, unix-gpu, website, miscellaneous, windows-cpu, clang, edge, windows-gpu, centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] kpuatamazon commented on pull request #19408: [LICENSE] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
kpuatamazon commented on pull request #19408:
URL: https://github.com/apache/incubator-mxnet/pull/19408#issuecomment-714729112
@mxnet-bot run ci [Greetings]
Greetings failed:interrobang: :confused: https://github.com/apache/incubator-mxnet/pull/19408/checks?check_run_id=1294654823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19408: [LICENSE] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19408:
URL: https://github.com/apache/incubator-mxnet/pull/19408#issuecomment-716445201
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19408: [LICENSE] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19408:
URL: https://github.com/apache/incubator-mxnet/pull/19408#issuecomment-714726485
Hey @kpuatamazon , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, centos-gpu, sanity, unix-gpu, website, miscellaneous, windows-cpu, clang, edge, windows-gpu, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] kpuatamazon commented on pull request #19408: [LICENSE] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
kpuatamazon commented on pull request #19408:
URL: https://github.com/apache/incubator-mxnet/pull/19408#issuecomment-716445165
@mxnet-bot run ci [unix-cpu]
This segfault seems like a problem, but not one I caused...
```
[2020-10-22T20:22:27.378Z] tests/python/unittest/test_contrib_control_flow.py::test_while_loop_simple_forward
[2020-10-22T20:22:27.378Z] Fatal Python error: Segmentation fault
[2020-10-22T20:22:27.378Z]
[2020-10-22T20:22:27.378Z] Thread 0x00007f750d470700 (most recent call first):
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 400 in read
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 432 in from_io
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 967 in _thread_receiver
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 220 in run
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 285 in _perform_spawn
[2020-10-22T20:22:27.378Z]
[2020-10-22T20:22:27.378Z] Current thread 0x00007f750e9fa740 (most recent call first):
[2020-10-22T20:22:27.378Z] File "/work/mxnet/python/mxnet/ndarray/ndarray.py", line 2600 in asnumpy
[2020-10-22T20:22:27.378Z] File "/work/mxnet/python/mxnet/numpy/multiarray.py", line 1353 in __repr__
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 56 in repr_instance
[2020-10-22T20:22:27.378Z] File "/usr/lib/python3.6/reprlib.py", line 65 in repr1
[2020-10-22T20:22:27.378Z] File "/usr/lib/python3.6/reprlib.py", line 55 in repr
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 47 in repr
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 82 in saferepr
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 689 in repr_args
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 780 in repr_traceback_entry
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 821 in repr_traceback
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 877 in repr_excinfo
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 631 in getrepr
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/nodes.py", line 326 in _repr_failure_py
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/reports.py", line 296 in from_item_and_call
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/runner.py", line 253 in pytest_runtest_makereport
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 187 in _multicall
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 87 in <lambda>
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 93 in _hookexec
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/hooks.py", line 286 in __call__
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/flaky/flaky_pytest_plugin.py", line 132 in call_and_report
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/runner.py", line 100 in runtestprotocol
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/runner.py", line 84 in pytest_runtest_protocol
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/flaky/flaky_pytest_plugin.py", line 92 in pytest_runtest_protocol
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 187 in _multicall
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 87 in <lambda>
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 93 in _hookexec
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/hooks.py", line 286 in __call__
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/xdist/remote.py", line 87 in run_one_test
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/xdist/remote.py", line 70 in pytest_runtestloop
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 187 in _multicall
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 87 in <lambda>
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 93 in _hookexec
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/hooks.py", line 286 in __call__
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/main.py", line 247 in _main
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/main.py", line 197 in wrap_session
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/_pytest/main.py", line 240 in pytest_cmdline_main
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 187 in _multicall
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 87 in <lambda>
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 93 in _hookexec
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/pluggy/hooks.py", line 286 in __call__
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/xdist/remote.py", line 258 in <module>
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 1084 in executetask
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 220 in run
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 285 in _perform_spawn
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 267 in integrate_as_primary_thread
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 1060 in serve
[2020-10-22T20:22:27.378Z] File "/usr/local/lib/python3.6/dist-packages/execnet/gateway_base.py", line 1554 in serve
[2020-10-22T20:22:27.378Z] File "<string>", line 8 in <module>
[2020-10-22T20:22:27.378Z] File "<string>", line 1 in <module>
[2020-10-22T20:22:27.378Z] Stack trace:
[2020-10-22T20:22:27.378Z] /lib/x86_64-linux-gnu/libc.so.6 ( + 0x3efd0) [0x7f750e442fd0]
[2020-10-22T20:22:27.378Z] /lib/x86_64-linux-gnu/libpthread.so.0 ( pthread_mutex_lock + 0 ) [0x7f750e1eefa0]
[2020-10-22T20:22:27.378Z] /work/mxnet/python/mxnet/../../build/libmxnet.so ( mxnet::engine::ThreadedEngine::WaitForVar(mxnet::engine::Var*) + 0x4a ) [0x7f74cdfcc82a]
[2020-10-22T20:22:27.378Z] /work/mxnet/python/mxnet/../../build/libmxnet.so ( mxnet::NDArray::SyncCopyToCPU(void*, unsigned long) const + 0x31c ) [0x7f74ce199c2c]
[2020-10-22T20:22:27.378Z] /work/mxnet/python/mxnet/../../build/libmxnet.so ( MXNDArraySyncCopyToCPU + 0x2b ) [0x7f74cdedb33b]
[2020-10-22T20:22:27.378Z] /usr/lib/x86_64-linux-gnu/libffi.so.6 ( ffi_call_unix64 + 0x4c ) [0x7f75078f8dae]
[2020-10-22T20:22:27.378Z] /usr/lib/x86_64-linux-gnu/libffi.so.6 ( ffi_call + 0x22f ) [0x7f75078f871f]
[2020-10-22T20:22:27.378Z] tests/python/unittest/test_contrib_control_flow.py::test_while_loop_nested
[2020-10-22T20:22:27.633Z] [gw3] [ 0%] PASSED tests/python/unittest/test_contrib_control_flow.py::test_while_loop_nested
[2020-10-22T20:22:27.633Z] [gw1] [ 0%] PASSED tests/python/unittest/test_contrib_control_flow.py::test_foreach
[2020-10-22T20:22:27.633Z] tests/python/unittest/test_contrib_control_flow.py::test_foreach_nested
[2020-10-22T20:22:27.633Z] [gw0] node down: Not properly terminated
[2020-10-22T20:22:27.633Z] [gw0] [ 0%] FAILED tests/python/unittest/test_base.py::test_data_dir
[2020-10-22T20:22:27.633Z]
[2020-10-22T20:22:27.633Z] replacing crashed worker gw0
[2020-10-22T20:22:27.633Z]
[gw4] linux Python 3.6.9 cwd: /work/mxnet
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #19408: [LICENSE] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19408:
URL: https://github.com/apache/incubator-mxnet/pull/19408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org