You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "GitToTheHub (via GitHub)" <gi...@apache.org> on 2026/05/18 15:16:03 UTC
[PR] fix: forward NSUserActivity to plugins via CDVSceneDelegate [cordova-ios]
GitToTheHub opened a new pull request, #1655:
URL: https://github.com/apache/cordova-ios/pull/1655
## Summary
`CDVSceneDelegate` was missing an implementation of `scene:continueUserActivity:`, which is the `UIWindowSceneDelegate` method iOS calls when an `NSUserActivity` event (i.e. a Universal Link with `NSUserActivityTypeBrowsingWeb`) is delivered to the active scene.
As a result, Universal Links were silently dropped when tapped inside `SFSafariViewController` on cordova-ios 8.x. On cordova-ios 7.x this worked because the activity was delivered to `AppDelegate.application(_:continue:restorationHandler:)` directly, before SceneDelegate was introduced.
## Changes
- **`CDVSceneDelegate.m`** — add `scene:continueUserActivity:` implementation that posts `CDVPluginContinueUserActivityNotification` via `NSNotificationCenter`, consistent with the existing URL-handling pattern.
- **`CDVPluginNotifications.h`** — declare the new `CDVPluginContinueUserActivityNotification` constant.
- **`CDVPlugin.m`** — define the new notification constant.
Plugins can now observe `CDVPluginContinueUserActivityNotification` to receive Universal Links and other `NSUserActivity` events.
Fixes #1654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix: forward NSUserActivity to plugins via CDVSceneDelegate [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #1655:
URL: https://github.com/apache/cordova-ios/pull/1655#issuecomment-4480240238
Works, when the plugin observes the new `CDVPluginContinueUserActivityNotification` notification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix: forward NSUserActivity to plugins via CDVSceneDelegate [cordova-ios]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1655:
URL: https://github.com/apache/cordova-ios/pull/1655#issuecomment-4479087061
## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1655?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.60%. Comparing base ([`e45c74d`](https://app.codecov.io/gh/apache/cordova-ios/commit/e45c74df51b5c170392765f101e7c509441485d7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`db494d4`](https://app.codecov.io/gh/apache/cordova-ios/commit/db494d49948ff2f0e414d5aef66cafecbd372c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (e45c74d) and HEAD (db494d4). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (e45c74d) | HEAD (db494d4) |
>|------|------|------|
>||10|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1655 +/- ##
==========================================
- Coverage 80.24% 74.60% -5.65%
==========================================
Files 17 17
Lines 5159 5159
==========================================
- Hits 4140 3849 -291
- Misses 1019 1310 +291
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1655?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix: forward NSUserActivity to plugins via CDVSceneDelegate [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #1655:
URL: https://github.com/apache/cordova-ios/pull/1655#issuecomment-4480232526
Hi [GitToTheHub](https://github.com/GitToTheHub),
I tested the plugin-side change in my fork:
https://github.com/hitomi0109/cordova-universal-links-plugin
After adding support for CDVPluginContinueUserActivityNotification in CULPlugin.m, Universal Links now work correctly in my environment with cordova-ios 8.
So PR https://github.com/apache/cordova-ios/pull/1655 on cordova-ios provides the necessary notification, and the plugin also needs to listen to that notification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix: forward NSUserActivity to plugins via CDVSceneDelegate [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub merged PR #1655:
URL: https://github.com/apache/cordova-ios/pull/1655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org