You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Sharath Reddy (JIRA)" <de...@myfaces.apache.org> on 2006/04/13 12:54:59 UTC
[jira] Created: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
New 'Outlook Menu' type component for Sandbox
----------------------------------------------
Key: TOMAHAWK-250
URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
Project: MyFaces Tomahawk
Type: New Feature
Reporter: Sharath Reddy
This component provides 'Outlook menu' type of component for MyFaces.
Features include:
1. Action and action listener can be specified for each menu option
2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component for Sandbox
Posted by Mike Kienenberger <mk...@gmail.com>.
On 4/28/06, Mario Ivankovits (JIRA) <de...@myfaces.apache.org> wrote:
> BTW: Why is it me, that I always get the complicated stuff :-(
Because you do all the work :)
[jira] Updated: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=all ]
Mario Ivankovits updated TOMAHAWK-250:
--------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Sharath, thanks for this great component!
As discussed with Sharath Reddy I renamed this component to "CollapsibleMenu".
@sharath: please check if the component still works as expected after the renaming. I tested it a little bit and it looked promising.
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=comments#action_12377007 ]
Mario Ivankovits commented on TOMAHAWK-250:
-------------------------------------------
sharath, in the meantime please check the collapsible.diff by applying it to your local repository (maybe you have to remove your old-named component before, or even better, use a clean checkout of tomahawk)
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: collapsible.diff, outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=comments#action_12377003 ]
Mario Ivankovits commented on TOMAHAWK-250:
-------------------------------------------
reverted patch in repository.
BTW: Why is it me, that I always get the complicated stuff :-(
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: collapsible.diff, outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=all ]
Mike Kienenberger updated TOMAHAWK-250:
---------------------------------------
Status: Patch Available (was: Open)
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=comments#action_12377432 ]
Mike Kienenberger commented on TOMAHAWK-250:
--------------------------------------------
Sharath,
It's really unclear from your submitted patches what work is "yours" and what work is distributed under a different license by Pragmatic Objects / Kevin H. Le.
Can you add the relevent original unmodified files to this issue so we can take a look.
We migth be able to get by with copying the Pragmatic Objects license into our "licenses" subdirectory (although I'm still having trouble locating this.
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: collapsible.diff, outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=comments#action_12374327 ]
Mario Ivankovits commented on TOMAHAWK-250:
-------------------------------------------
"Adapted from the original component developed by Kevin Le (http://pragmaticobjects.com)" does this mean you copied some source from there?
If so, what license was/is it?
Where did you have the icons from? Whats their license?
Would it be possible to use "org.apache.myfaces.custom.navmenu.NavigationMenuItem" to configure the component.
That way it could be an easy replacement and we should try to keep our configurations slick.
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Reporter: Sharath Reddy
> Attachments: patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=comments#action_12376947 ]
Mike Kienenberger commented on TOMAHAWK-250:
--------------------------------------------
Another issue is that you need to rename this. "Outlook" is trademarked.
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=all ]
Mike Kienenberger reopened TOMAHAWK-250:
----------------------------------------
On 4/28/06, imario@apache.org <im...@apache.org> wrote:
> Author: imario
> Date: Fri Apr 28 13:38:01 2006
> New Revision: 397999
>
> URL: http://svn.apache.org/viewcvs?rev=397999&view=rev
> Log:
> TOMAHAWK-250: collapsible menu (like the left handed menu you know from outlook)
> great stuff, thanks to Sharath Reddy for this great component
Mario,
This is not an acceptable patch. A previous thread stated that the original copyright on some of this code is under a different license, yet I see no mention of that license in your committed code.
http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c20060413122851.68627.qmail@web30508.mail.mud.yahoo.com%3e
There's no issue with the BSD-esque licensed code being included provided it's included in our LICENSE file/directory, but we cannot arbitrarily strip the BSD license from the code.
Until this licensing issue is cleared up, please revert your patch.
-Mike
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=comments#action_12377433 ]
Mike Kienenberger commented on TOMAHAWK-250:
--------------------------------------------
Note to whoever commits this:
The license file would go into tomahawk\sandbox\core\src\main\resources\licenses and would need to be menitioned in the tomahawk\sandbox\core\src\main\resources\licenses\NOTICE.txt file.
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: collapsible.diff, outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-250) New 'Outlook Menu' type component
for Sandbox
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-250?page=comments#action_12378620 ]
Mario Ivankovits commented on TOMAHAWK-250:
-------------------------------------------
Sharath Reddy filed a CLA and Kevin Le filed a corporate CLA - where can we check the corporate CLAs?
The code Sharaths work is based on is all written by Kevin. The JSF part is done by Sharath.
Whats required to fix this issue now?
I think the best will be to get rid of the custom license, how can Kevin donate his code so that we can release it under the terms of ASF?
Is it sufficient if he post a comment here?
> New 'Outlook Menu' type component for Sandbox
> ----------------------------------------------
>
> Key: TOMAHAWK-250
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-250
> Project: MyFaces Tomahawk
> Type: New Feature
> Components: New Component
> Reporter: Sharath Reddy
> Assignee: Mario Ivankovits
> Attachments: collapsible.diff, outlookMenu2.zip, patch.zip
>
> This component provides 'Outlook menu' type of component for MyFaces.
> Features include:
> 1. Action and action listener can be specified for each menu option
> 2. Menu can be constructed dynamically from a backing bean as demonstrated in the example
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira