You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/02/26 09:23:27 UTC
[PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
mdedetrich opened a new pull request, #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116
Trying this with pekko core, this is what it looks like with this change (there should be no difference in rendered text)
And when setting `pekkoParadoxIncubatorNotice` to `None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116#discussion_r1502294285
##########
theme/src/main/assets/partials/footer.st:
##########
@@ -67,9 +67,11 @@ $!
</a>
</div>
<div class="incubation-disclaimer">
- <p>
- Apache Pekko is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.
- </p>
+ $ if (page.properties.("incubator.notice")) $
+ <p>
+ $page.properties.("incubator.notice")$
+ </p>
+ $ endif $
Review Comment:
could we include this in the `if`?
```
<div class="logo">
<a href="https://incubator.apache.org/" one-link-mark="yes">
<img src="$page.properties.("assets.hostname")$assets/images/apache-incubator.svg" alt="Apache Incubator logo" id="incubator__logo">
</a>
</div>
```
we don't want the incubator logo after we leave the Incubator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116#issuecomment-1963719418
I have no problem with the implementation of this PR, Thanks @mdedetrich, but I have some suggestions for improving the final render: Can we change the layout of the footer?
I think the styles of https://fury.apache.org/ and https://answer.apache.org/ are easier to migrate to the Apache Top Level Project, which will not lead to a large area of white space, in the end, it will be looks like: https://storm.apache.org/ and https://opendal.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116#discussion_r1502280976
##########
plugin/src/main/scala/org/apache/pekko/PekkoParadoxPlugin.scala:
##########
@@ -31,11 +31,15 @@ object PekkoParadoxPlugin extends AutoPlugin {
object autoImport {
val pekkoParadoxCopyright = settingKey[String]("Copyright text to use in docs footer")
val pekkoParadoxGithub = settingKey[Option[String]]("Link to Github repository")
+ val pekkoParadoxIncubatorNotice = settingKey[Option[String]]("Whether to include the ASF incubator notice")
}
import autoImport._
val version = ParadoxPlugin.readProperty("pekko-paradox.properties", "pekko.paradox.version")
+ val incubatorNoticeText =
Review Comment:
I put the text into a publicly accessible `val` so that if we set the default value of `pekkoParadoxIncubatorNotice` to `None` (which we will do in the future at some point) if for some reason someone wants to access the original text they can
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116#discussion_r1502295224
##########
theme/src/main/assets/partials/footer.st:
##########
@@ -67,9 +67,11 @@ $!
</a>
</div>
<div class="incubation-disclaimer">
- <p>
- Apache Pekko is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.
- </p>
+ $ if (page.properties.("incubator.notice")) $
+ <p>
+ $page.properties.("incubator.notice")$
+ </p>
+ $ endif $
Review Comment:
Ah right, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116#issuecomment-1963707201
This is what it looks like now which is a lot better
Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116#issuecomment-1963721423
> This is what it looks like now which is a lot better
I also agree with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make incubator notice optional [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #116:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org