You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/05/06 20:21:37 UTC
[GitHub] [nifi] mtien-apache opened a new pull request #4258: NIFI-7423 Upgraded jquery dependency version.
mtien-apache opened a new pull request #4258:
URL: https://github.com/apache/nifi/pull/4258
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Upgraded jquery dependency version._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #4258: NIFI-7423 Upgraded jquery dependency version.
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #4258:
URL: https://github.com/apache/nifi/pull/4258#issuecomment-624928081
@andrewmlim Yes, I agree 3.5.1 makes sense. I'll upgrade now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #4258: NIFI-7423 Upgraded jquery dependency version.
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #4258:
URL: https://github.com/apache/nifi/pull/4258#issuecomment-625427730
@andrewmlim Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] andrewmlim commented on pull request #4258: NIFI-7423 Upgraded jquery dependency version.
Posted by GitBox <gi...@apache.org>.
andrewmlim commented on pull request #4258:
URL: https://github.com/apache/nifi/pull/4258#issuecomment-625426549
+1 LGTM. Did not see any regression or unexpected behavior while running through the UI with these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] andrewmlim commented on pull request #4258: NIFI-7423 Upgraded jquery dependency version.
Posted by GitBox <gi...@apache.org>.
andrewmlim commented on pull request #4258:
URL: https://github.com/apache/nifi/pull/4258#issuecomment-624918105
Will help review by performing regression testing on the NiFI UI.
@mtien-apache jQuery 3.5.1 was released two days ago. Would it make sense to upgrade to the latest or was choosing 3.5.0 intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #4258: NIFI-7423 Upgraded jquery dependency version.
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #4258:
URL: https://github.com/apache/nifi/pull/4258#issuecomment-625475256
Will review...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #4258: NIFI-7423 Upgraded jquery dependency version.
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #4258:
URL: https://github.com/apache/nifi/pull/4258#issuecomment-625922140
Thanks for the PR @mtien-apache! Thanks for the review @andrewmlim! This has been merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org