You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "harinreddy (Code Review)" <ge...@cloudera.org> on 2022/09/19 03:35:28 UTC
[kudu-CR] Adds opname test for ‘BLR” for ppc64le architecture ppc64le does not have the assembler instruction “RET”. This patch adds opname test for “BLR” which is euivalent to “RET” opcode.
harinreddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19016
Change subject: Adds opname test for ‘BLR” for ppc64le architecture ppc64le does not have the assembler instruction “RET”. This patch adds opname test for “BLR” which is euivalent to “RET” opcode.
......................................................................
Adds opname test for ‘BLR” for ppc64le architecture
ppc64le does not have the assembler instruction “RET”.
This patch adds opname test for “BLR” which is euivalent to
“RET” opcode.
Changes to be committed:
modified: src/kudu/codegen/code_generator.cc
Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
---
M src/kudu/codegen/code_generator.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/19016/1
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 1
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19016 )
Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 4
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 15 Jan 2023 17:50:23 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 4
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19016 )
Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
......................................................................
Patch Set 4: Verified+1
unrelated test failure in EnableKudu1097AndDownTS/MoveTabletParamTest.Test/5 (ASAN)
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 4
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 15 Jan 2023 17:50:16 +0000
Gerrit-HasComments: No
[kudu-CR] Adds opname test for ‘BLR” for ppc64le architecture
Posted by "harinreddy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19016
to look at the new patch set (#2).
Change subject: Adds opname test for ‘BLR” for ppc64le architecture
......................................................................
Adds opname test for ‘BLR” for ppc64le architecture
ppc64le does not have the assembler instruction “RET”.
This patch adds opname test for “BLR” which is euivalent to
“RET” opcode.
Changes to be committed:
modified: src/kudu/codegen/code_generator.cc
Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
---
M src/kudu/codegen/code_generator.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/19016/2
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19016 )
Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
......................................................................
[codegen] use "BLR" instead of "RET" for ppc64le
ppc64le does not have the assembler instruction "RET".
This patch updates the codegen to handle the "BLR" instruction
(Branch to Link Register) for ppc64 which is equivalent to "RET"
in x86_64.
Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Reviewed-on: http://gerrit.cloudera.org:8080/19016
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/codegen/code_generator.cc
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 5
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [codegen] use "BLR" instead of "RET" for ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by harinreddy. ( http://gerrit.cloudera.org:8080/19016 )
Change subject: [codegen] use "BLR" instead of "RET" for ppc64le
......................................................................
[codegen] use "BLR" instead of "RET" for ppc64le
ppc64le does not have the assembler instruction "RET".
This patch updates the codegen to handle the "BLR" instruction
(Branch to Link Register) for ppc64 which is equivalent to "RET"
in x86_64.
Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
---
M src/kudu/codegen/code_generator.cc
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/19016/4
--
To view, visit http://gerrit.cloudera.org:8080/19016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia40f902b14c899a2efc0bed3d3fc31376d516db7
Gerrit-Change-Number: 19016
Gerrit-PatchSet: 4
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)