You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2025/12/27 17:44:30 UTC
[PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
voonhous opened a new pull request, #17728:
URL: https://github.com/apache/hudi/pull/17728
### Describe the issue this Pull Request addresses
This PR refactors the `hudi-sync` modules to reduce boilerplate code by leveraging Project Lombok annotations. Specifically, it replaces explicit `Logger` instantiation, manual getter/setter methods, and empty constructors with their equivalent Lombok annotations (`@Slf4j`, `@Getter`, `@Setter`,`@NoArgsConstructor`, `@AllArgsConstructor`, `@Data`, `@Value`, `@ToString`).
This improves code readability and maintainability without altering the runtime logic.
### Summary and Changelog
This change introduces the Lombok dependency to the `hudi-sync` modules and refactors several classes to utilize Lombok annotations.
- Added Lombok annotations wherever possible to `hudi-sync` modules.
### Impact
- **Public API:** None.
- **User Experience:** No visible change for end-users.
- **Performance:** No impact (compile-time code generation).
- **Code Health:** Reduces lines of code and standardizes logging/accessor patterns.
### Risk Level
none
(This is a pure refactoring change involving standard library annotations; no business logic was modified.)
### Documentation Update
none
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [x] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3731801347
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
}, {
"hash" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608",
"triggerID" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"triggerType" : "PUSH"
}, {
"hash" : "291468ecb21170f084bdd4de126d1cec9e08a604",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "291468ecb21170f084bdd4de126d1cec9e08a604",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 142af604008062bb3af942aae5f5c6bf59fff0c0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608)
* 291468ecb21170f084bdd4de126d1cec9e08a604 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3694151894
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
}, {
"hash" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606)
* 142af604008062bb3af942aae5f5c6bf59fff0c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3731802686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
}, {
"hash" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608",
"triggerID" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"triggerType" : "PUSH"
}, {
"hash" : "291468ecb21170f084bdd4de126d1cec9e08a604",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10913",
"triggerID" : "291468ecb21170f084bdd4de126d1cec9e08a604",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 142af604008062bb3af942aae5f5c6bf59fff0c0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608)
* 291468ecb21170f084bdd4de126d1cec9e08a604 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10913)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3694200637
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
}, {
"hash" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608",
"triggerID" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 142af604008062bb3af942aae5f5c6bf59fff0c0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3694120965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3694121665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #17728:
URL: https://github.com/apache/hudi/pull/17728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3694181239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
}, {
"hash" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608",
"triggerID" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606)
* 142af604008062bb3af942aae5f5c6bf59fff0c0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3731860557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
}, {
"hash" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608",
"triggerID" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"triggerType" : "PUSH"
}, {
"hash" : "291468ecb21170f084bdd4de126d1cec9e08a604",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10913",
"triggerID" : "291468ecb21170f084bdd4de126d1cec9e08a604",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 291468ecb21170f084bdd4de126d1cec9e08a604 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10913)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3731800619
@CTTY Can you please help to review this too, thank you so much :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok annotations to hudi-sync modules [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17728:
URL: https://github.com/apache/hudi/pull/17728#issuecomment-3694154685
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606",
"triggerID" : "23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9",
"triggerType" : "PUSH"
}, {
"hash" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608",
"triggerID" : "142af604008062bb3af942aae5f5c6bf59fff0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23f09aa1ba97dab52dc80cc9c64d8d633eeb2ba9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10606)
* 142af604008062bb3af942aae5f5c6bf59fff0c0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10608)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org