You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/07/12 01:04:51 UTC
[jira] Created: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
improve test coverage of BufferedRandomAccessFile
-------------------------------------------------
Key: CASSANDRA-1269
URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
Project: Cassandra
Issue Type: Task
Components: Core
Reporter: Jonathan Ellis
Assignee: Jon Hermes
Priority: Minor
Fix For: 0.7
We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895508#action_12895508 ]
Stu Hood commented on CASSANDRA-1269:
-------------------------------------
> Can you clarify what you mean by that last?
Aha, missed the "100% line coverage." portion. Aside from my other comment above, +1.
> improve test coverage of BufferedRandomAccessFile
> -------------------------------------------------
>
> Key: CASSANDRA-1269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1269.txt
>
>
> We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896356#action_12896356 ]
Hudson commented on CASSANDRA-1269:
-----------------------------------
Integrated in Cassandra #510 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/510/])
improve BufferedRandomAccessFileTest coverage to 100% of lines. patch by Jon Hermes; reviewed by jbellis for CASSANDRA-1269
flesh out BufferedRandomAccessFileTest. patch by Jon Hermes; reviewed by Stu Hood for CASSANDRA-1269
> improve test coverage of BufferedRandomAccessFile
> -------------------------------------------------
>
> Key: CASSANDRA-1269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1269-v2.txt, 1269.txt
>
>
> We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895105#action_12895105 ]
Jonathan Ellis commented on CASSANDRA-1269:
-------------------------------------------
Can you clarify what you mean by that last? Personally, I want to be confident that errors at the storage layer are from regressions in our sstable logic, rather than BRAF (which I made some pretty large change to during 0.7). So, we're trying to test "everything." 100% line coverage is a reasonable approximation to that.
> improve test coverage of BufferedRandomAccessFile
> -------------------------------------------------
>
> Key: CASSANDRA-1269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1269.txt
>
>
> We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895513#action_12895513 ]
Jonathan Ellis commented on CASSANDRA-1269:
-------------------------------------------
committed, reverting the change to BRAF itself and substituting FileMark in the test.
is BRAFTest achieving 100% line coverage by itself now, or is that the coverage we get from all the stuff the rest of the Cassandra suite is doing?
> improve test coverage of BufferedRandomAccessFile
> -------------------------------------------------
>
> Key: CASSANDRA-1269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1269.txt
>
>
> We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895053#action_12895053 ]
Stu Hood commented on CASSANDRA-1269:
-------------------------------------
The test looks fine, but BufferedRandomAccessFileMark doesn't need to be public.
Also, is this sufficient to close the ticket? We should probably indicate exactly what it is we're trying to test in the future.
> improve test coverage of BufferedRandomAccessFile
> -------------------------------------------------
>
> Key: CASSANDRA-1269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1269.txt
>
>
> We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1269:
----------------------------------
Attachment: 1269-v2.txt
BRAFTest now has 100% cc by itself.
> improve test coverage of BufferedRandomAccessFile
> -------------------------------------------------
>
> Key: CASSANDRA-1269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1269-v2.txt, 1269.txt
>
>
> We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1269) improve test coverage of
BufferedRandomAccessFile
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1269:
----------------------------------
Attachment: 1269.txt
Reads tested some more.
Overflow case tested some more.
100% line coverage.
> improve test coverage of BufferedRandomAccessFile
> -------------------------------------------------
>
> Key: CASSANDRA-1269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1269
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: 1269.txt
>
>
> We have a BRAFTest but it doesn't do a whole lot. Seems like we ought to be able to get to 100% line-based coverage w/ white-box testing. http://wiki.apache.org/cassandra/HowToContribute has instructions for setting up code coverage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.