You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/25 00:28:52 UTC
[GitHub] [kafka] LiamClarkeNZ opened a new pull request, #12557: Fix small regression, where WorkerTest was re-disabled for Java 16+. …
LiamClarkeNZ opened a new pull request, #12557:
URL: https://github.com/apache/kafka/pull/12557
…As it no longer uses Powermock, it can be run on Java 16+
Signed-off-by: Liam Clarke-Hutchinson <li...@steelsky.co.nz>
Verified by running unit test with following JVM:
```
liam.clarke-hutchinson@ELH-5AMD6R ~/d/kafka (WorkerTestJava16)> java -version
openjdk version "18.0.2" 2022-07-19
OpenJDK Runtime Environment Temurin-18.0.2+9 (build 18.0.2+9)
OpenJDK 64-Bit Server VM Temurin-18.0.2+9 (build 18.0.2+9, mixed mode, sharing)
```
### Committer Checklist (excluded from commit message)
- [X] Verify design and implementation
- [X] Verify test coverage and CI build status
- [X] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12557: MINOR: re-enable WorkerTest for java 16+
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12557:
URL: https://github.com/apache/kafka/pull/12557#issuecomment-1226808195
Failed tests are un-relabed.
Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterSnapshotTest.testSnapshotsGenerated()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #12557: MINOR: re-enable WorkerTest for java 16+
Posted by GitBox <gi...@apache.org>.
showuon merged PR #12557:
URL: https://github.com/apache/kafka/pull/12557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] LiamClarkeNZ commented on pull request #12557: Fix small regression, where WorkerTest was re-disabled for Java 16+. …
Posted by GitBox <gi...@apache.org>.
LiamClarkeNZ commented on PR #12557:
URL: https://github.com/apache/kafka/pull/12557#issuecomment-1226724531
Hey @showuon! No, I'm _re-enabling_ `WorkerTest` for test runs under Java 16+, not disabling it :)
It was excluded from test runs under Java 16+ previously, because it used PowerMock, which does not work for Java 16+. But I refactored it to use Mockito some time ago, and removed it from the Java 16 exclusion list.
A later PR accidentally added it back to the Java 16 exclusion list.
Does that make sense? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12557: Fix small regression, where WorkerTest was re-disabled for Java 16+. …
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12557:
URL: https://github.com/apache/kafka/pull/12557#issuecomment-1226709342
Sorry @LiamClarkeNZ , could you explain more why we should disable WorkerTest? It doesn't fail in the latest trunk build, where jdk 8 and jdk 11 runs well.
https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/1172/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org