You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Sébastien Brisard <se...@m4x.org> on 2012/05/28 09:42:55 UTC
[math] SparseRealVectorTest, SparseRealMatrixTest,
SparseFieldMatrixTest, SparseFieldVectorTest
Hi,
is there a reason why these classes are called SparseXxxTest, instead
of OpenMapXxxTest? Am I missing something?
Sébastien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] SparseRealVectorTest, SparseRealMatrixTest,
SparseFieldMatrixTest, SparseFieldVectorTest
Posted by Sébastien Brisard <se...@m4x.org>.
Hi,
2012/5/28 Thomas Neidhart <th...@gmail.com>:
> On 05/28/2012 11:23 AM, Luc Maisonobe wrote:
>> Le 28/05/2012 09:42, Sébastien Brisard a écrit :
>>> Hi,
>>> is there a reason why these classes are called SparseXxxTest, instead
>>> of OpenMapXxxTest? Am I missing something?
>>
>> I don't remember the reason, it may either be that we renamed the
>> library class and forgot to rename the test classes, or we intended to
>> share base test class accross several different implementations and did
>> not do it.
>>
I'm currently looking into the tests of all vectors implementations,
and there is *a lot* of duplicate code. I will probably factor out
some of this code into the newly created RealVectorAbstractTest (which
I've set up for the sake of testing the various implementations of the
visitor pattern).
>> Nevertheless, they could be renamed for consistency. As they are only
>> test classes, there are no compatibility issues there.
>>
>> Thanks for identifying this.
>
> fyi: there is already an issue about this MATH-625
>
> Thomas
>
Thomas, you are a living encyclopedia! Thanks for the hint, I you
want, I can take care of that ticket.
Best regards,
Sébastien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] SparseRealVectorTest, SparseRealMatrixTest, SparseFieldMatrixTest,
SparseFieldVectorTest
Posted by Thomas Neidhart <th...@gmail.com>.
On 05/28/2012 11:23 AM, Luc Maisonobe wrote:
> Le 28/05/2012 09:42, Sébastien Brisard a écrit :
>> Hi,
>> is there a reason why these classes are called SparseXxxTest, instead
>> of OpenMapXxxTest? Am I missing something?
>
> I don't remember the reason, it may either be that we renamed the
> library class and forgot to rename the test classes, or we intended to
> share base test class accross several different implementations and did
> not do it.
>
> Nevertheless, they could be renamed for consistency. As they are only
> test classes, there are no compatibility issues there.
>
> Thanks for identifying this.
fyi: there is already an issue about this MATH-625
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] SparseRealVectorTest, SparseRealMatrixTest, SparseFieldMatrixTest,
SparseFieldVectorTest
Posted by Luc Maisonobe <Lu...@free.fr>.
Le 28/05/2012 09:42, Sébastien Brisard a écrit :
> Hi,
> is there a reason why these classes are called SparseXxxTest, instead
> of OpenMapXxxTest? Am I missing something?
I don't remember the reason, it may either be that we renamed the
library class and forgot to rename the test classes, or we intended to
share base test class accross several different implementations and did
not do it.
Nevertheless, they could be renamed for consistency. As they are only
test classes, there are no compatibility issues there.
Thanks for identifying this.
Luc
> Sébastien
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org