You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/20 13:43:13 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request, #20144: feat: showing results pane in dashboard
zhaoyongjie opened a new pull request, #20144:
URL: https://github.com/apache/superset/pull/20144
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Show results pane in Dashboard. This PR has to wait for [PR](https://github.com/apache/superset/pull/20109) merged
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
https://user-images.githubusercontent.com/2016594/169540783-bec01028-ba4e-409d-a475-1e0166b522db.mov
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1133358796
Loving this!!
Capturing a few UI/UX change requests that have come up in design feedback (CC @kasiazjc ❤️ )
* In the modal header, instead of "View Results" maybe we could get more specific, like one of these:
* {Name} Data
* {Name} Results
* Chart Data: {Name}
* ... or others?
* In the footer of the modal, can we add two buttons?
* (left/secondary button) "Open in Explore" (or is this "Edit chart" now?)
* (right/primary button) "Close"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #20144:
URL: https://github.com/apache/superset/pull/20144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1145528539
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20144:
URL: https://github.com/apache/superset/pull/20144#discussion_r889690832
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -327,6 +330,41 @@ class SliceHeaderControls extends React.PureComponent<
</Menu.Item>
)}
+ {this.props.supersetCanExplore && (
+ <Menu.Item key={MENU_KEYS.VIEW_RESULTS}>
+ <ModalTrigger
+ triggerNode={
+ <span data-test="view-query-menu-item">
+ {t('View results')}
+ </span>
+ }
+ modalTitle={t('Chart Data: %s', slice.slice_name)}
+ modalBody={
+ <ResultsPane
+ queryFormData={this.props.formData}
+ queryForce={false}
+ dataSize={20}
+ isRequest
+ />
+ }
+ modalFooter={
+ <>
Review Comment:
nice catch! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #20144:
URL: https://github.com/apache/superset/pull/20144#discussion_r889119367
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -327,6 +330,41 @@ class SliceHeaderControls extends React.PureComponent<
</Menu.Item>
)}
+ {this.props.supersetCanExplore && (
+ <Menu.Item key={MENU_KEYS.VIEW_RESULTS}>
+ <ModalTrigger
+ triggerNode={
+ <span data-test="view-query-menu-item">
+ {t('View results')}
+ </span>
+ }
+ modalTitle={t('Chart Data: %s', slice.slice_name)}
+ modalBody={
+ <ResultsPane
+ queryFormData={this.props.formData}
+ queryForce={false}
+ dataSize={20}
+ isRequest
+ />
+ }
+ modalFooter={
+ <>
Review Comment:
I think that React.Fragment is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1135482929
I also really love this feature! This will also be the perfect mechanism for showing raw data underlying a highlighted slice on a chart (project Drill Down)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1146289014
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1134701358
> Loving this!!
>
> Capturing a few UI/UX change requests that have come up in design feedback (CC @kasiazjc ❤️ )
>
> * In the modal header, instead of "View Results" maybe we could get more specific, like one of these:
>
> * {Name} Data
> * {Name} Results
> * Chart Data: {Name}
> * ... or others?
> * In the footer of the modal, can we add two buttons?
>
> * (left/secondary button) "Open in Explore" (or is this "Edit chart" now?)
> * (right/primary button) "Close"
Thanks @rusackas for adding those and @zhaoyongjie for working on it ❤️
Following up:
1. I think we should definitely add a footer.
2. The best title would probably be your third idea "Chart data: {Name}", because if the chart has a still long name users will still be able to see the context as it's right at the beginning!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1146832830
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1145525646
# [Codecov](https://codecov.io/gh/apache/superset/pull/20144?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20144](https://codecov.io/gh/apache/superset/pull/20144?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f3a176) into [master](https://codecov.io/gh/apache/superset/commit/a020f75a974de1108578e5629d8783494cd5d512?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a020f75) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 2f3a176 differs from pull request most recent head ebb6f63. Consider uploading reports for the commit ebb6f63 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20144 +/- ##
==========================================
+ Coverage 66.53% 66.55% +0.01%
==========================================
Files 1726 1726
Lines 64861 64858 -3
Branches 6829 6830 +1
==========================================
+ Hits 43157 43164 +7
+ Misses 19972 19964 -8
+ Partials 1732 1730 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.36% <100.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/SliceHeaderControls/index.tsx](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | `64.28% <100.00%> (+0.43%)` | :arrow_up: |
| [.../src/explore/components/DataTableControl/index.tsx](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sL2luZGV4LnRzeA==) | `64.04% <0.00%> (-5.19%)` | :arrow_down: |
| [...mponents/DataTablesPane/components/ResultsPane.tsx](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL1Jlc3VsdHNQYW5lLnRzeA==) | `58.18% <0.00%> (-0.75%)` | :arrow_down: |
| [...mponents/DataTablesPane/components/SamplesPane.tsx](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL1NhbXBsZXNQYW5lLnRzeA==) | `69.76% <0.00%> (-0.69%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.ts](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy50cw==) | `50.00% <0.00%> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `0.00% <0.00%> (ø)` | |
| [...ts/DataTablesPane/components/DataTableControls.tsx](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL0RhdGFUYWJsZUNvbnRyb2xzLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...lore/components/useOriginalFormattedTimeColumns.ts](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy91c2VPcmlnaW5hbEZvcm1hdHRlZFRpbWVDb2x1bW5zLnRz) | | |
| [...d/src/explore/components/DataTableControl/utils.ts](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sL3V0aWxzLnRz) | `75.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `88.05% <0.00%> (+1.49%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/20144/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20144?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20144?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a020f75...ebb6f63](https://codecov.io/gh/apache/superset/pull/20144?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20144: feat: showing results pane in dashboard
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20144:
URL: https://github.com/apache/superset/pull/20144#issuecomment-1145529299
@zhaoyongjie Ephemeral environment spinning up at http://35.167.214.140:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org