[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9767: Filter SNI based on port

["JosiahWI (via GitHub)" <gi...@apache.org>]

JosiahWI commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1222062023


##########
iocore/net/SSLSNIConfig.cc:
##########
@@ -111,80 +113,72 @@ int
 SNIConfigParams::load_sni_config()
 {
   for (auto &item : yaml_sni.items) {
-    auto ai = sni_action_list.emplace(sni_action_list.end());
-    ai->set_glob_name(item.fqdn);
+    auto &ai = sni_action_list.emplace_back();
+    ai.set_glob_name(item.fqdn);
+    if (!item.port_ranges.empty()) {
+      auto const [min, max]{item.port_ranges[0]};

Review Comment:
   There is only one element; I'm planning to implement support for multiple port ranges immediately after this PR is finished.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org