You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by dlyle65535 <gi...@git.apache.org> on 2016/10/25 15:01:35 UTC

[GitHub] incubator-metron pull request #322: METRON-513: Ambari MP Metainfo should no...

GitHub user dlyle65535 opened a pull request:

    https://github.com/apache/incubator-metron/pull/322

    METRON-513: Ambari MP Metainfo should not advertise version

    Set versionAdvertised to false in metainfo.xml for the MPack.
    
    Prior to this change, the cluster would report the Metron host as "OUT_OF_SYNC".
    
    Tested on Docker cluster following procedure here: [Metron MPack](https://www.evernote.com/l/AhLFVR-9CsFIYYnOnF43BlxSsT4F856qwaY)
    
    No longer reports "OUT_OF_SYNC"
    > curl -H "X-Requested-By: ambari" -X GET -u admin:admin 
    http://localhost:8080/api/v1/clusters/docker-metron/stack_versions/1
    > {
    >  "ClusterStackVersions" : {
    >     "cluster_name" : "docker-metron",
    >     "id" : 1,
    >     "repository_version" : 1,
    >     "stack" : "HDP",
    >     "state" : "CURRENT",
    >     "version" : "2.4",
    >     "host_states" : {
    >       "CURRENT" : [
    >         "amb1.service.consul",
    >         "amb2.service.consul",
    >         "amb3.service.consul",
    >         "amb4.service.consul"
    >       ],
    >       "INIT" : [ ],
    >       "INSTALLED" : [ ],
    >       "INSTALLING" : [ ],
    >       "INSTALL_FAILED" : [ ],
    >       "NOT_REQUIRED" : [ ],
    >       "OUT_OF_SYNC" : [ ]
    >     }

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlyle65535/incubator-metron METRON-513

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #322
    
----
commit 40e719889baa83c2ecc1961a62f9e1c06102b294
Author: David Lyle <dl...@gmail.com>
Date:   2016-10-25T14:56:18Z

    METRON-513: Ambari Management Pack Metainfo should not advertise version.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron pull request #322: METRON-513: Ambari MP Metainfo should no...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-metron/pull/322


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #322: METRON-513: Ambari MP Metainfo should not adver...

Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:

    https://github.com/apache/incubator-metron/pull/322
  
    Great - that is what we need to verify


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #322: METRON-513: Ambari MP Metainfo should not adver...

Posted by nsinha17 <gi...@git.apache.org>.
Github user nsinha17 commented on the issue:

    https://github.com/apache/incubator-metron/pull/322
  
    +1 (non-binding) 
    I tested this out in the openstack environment and the fix looks good.
    Steps followed for testing:-
    1. Built the Mpack and RPMs by pulling out the code from dlyle65535:METRON-513
    2. Installed Metron and related services on the 12 node openstack cluster.
    3. Navigated to "Admin->Stacks and versions" page in Ambari UI and the services' status showed up as expected.
    Attached is the image :-
    ![screen shot 2016-10-26 at 2 13 21 pm](https://cloud.githubusercontent.com/assets/19325569/19719305/fbf45316-9b86-11e6-952d-d93422e325f3.png)
    
    ![screen shot 2016-10-26 at 2 14 08 pm](https://cloud.githubusercontent.com/assets/19325569/19719315/059d7fb4-9b87-11e6-9862-0170a24a4e49.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #322: METRON-513: Ambari MP Metainfo should not adver...

Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:

    https://github.com/apache/incubator-metron/pull/322
  
    +1 by inspection, great job @dlyle65535 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #322: METRON-513: Ambari MP Metainfo should not adver...

Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:

    https://github.com/apache/incubator-metron/pull/322
  
    So, prior to this patch, the OUT_OF_SYNC array in the stack_versions report would have been populated with the host where Metron was installed. That would make the cluster un-upgradeable and also has some interactions with the Add Service Wizard that are problematic. This will take care of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #322: METRON-513: Ambari MP Metainfo should not adver...

Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:

    https://github.com/apache/incubator-metron/pull/322
  
    What does it report then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #322: METRON-513: Ambari MP Metainfo should not adver...

Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:

    https://github.com/apache/incubator-metron/pull/322
  
    Hi @ottobackwards , it correctly reports the cluster is CURRENT unless one of the other stack components aren't. That logic doesn't apply to the Metron service because it is an add-on and not directly part of the HDP stack. So when I originally had set versionAdvertised to true, it was a bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---