You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/25 05:26:36 UTC
[GitHub] [ozone] sky76093016 opened a new pull request #2368: HDDS-5387. ProfileServlet to move the default output location to an ozone specific directory
sky76093016 opened a new pull request #2368:
URL: https://github.com/apache/ozone/pull/2368
## What changes were proposed in this pull request?
Sharing the output directory causes permission error, because typically they are run by separate users.
We should use an output directory specific to Ozone to avoid the permission issue.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5387
## How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #2368: HDDS-5387. ProfileServlet to move the default output location to an ozone specific directory
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #2368:
URL: https://github.com/apache/ozone/pull/2368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2368: HDDS-5387. ProfileServlet to move the default output location to an ozone specific directory
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2368:
URL: https://github.com/apache/ozone/pull/2368#discussion_r658608327
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/ProfileServlet.java
##########
@@ -129,7 +129,7 @@
private static final int DEFAULT_DURATION_SECONDS = 10;
private static final AtomicInteger ID_GEN = new AtomicInteger(0);
static final Path OUTPUT_DIR =
- Paths.get(System.getProperty("java.io.tmpdir"), "prof-output");
+ Paths.get(System.getProperty("java.io.tmpdir"), "prof-output-ozone");
Review comment:
Just a question do we need to add some random number to it, so that we don't append output to same file again after restart?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on a change in pull request #2368: HDDS-5387. ProfileServlet to move the default output location to an ozone specific directory
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #2368:
URL: https://github.com/apache/ozone/pull/2368#discussion_r658611498
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/ProfileServlet.java
##########
@@ -129,7 +129,7 @@
private static final int DEFAULT_DURATION_SECONDS = 10;
private static final AtomicInteger ID_GEN = new AtomicInteger(0);
static final Path OUTPUT_DIR =
- Paths.get(System.getProperty("java.io.tmpdir"), "prof-output");
+ Paths.get(System.getProperty("java.io.tmpdir"), "prof-output-ozone");
Review comment:
no that's not needed. this is the directory name. files names are prepended with the start time, and created in this directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2368: HDDS-5387. ProfileServlet to move the default output location to an ozone specific directory
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2368:
URL: https://github.com/apache/ozone/pull/2368#discussion_r658617644
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/ProfileServlet.java
##########
@@ -129,7 +129,7 @@
private static final int DEFAULT_DURATION_SECONDS = 10;
private static final AtomicInteger ID_GEN = new AtomicInteger(0);
static final Path OUTPUT_DIR =
- Paths.get(System.getProperty("java.io.tmpdir"), "prof-output");
+ Paths.get(System.getProperty("java.io.tmpdir"), "prof-output-ozone");
Review comment:
Thanks @jojochuang for info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2368: HDDS-5387. ProfileServlet to move the default output location to an ozone specific directory
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2368:
URL: https://github.com/apache/ozone/pull/2368#issuecomment-868357748
Thank You @sky76093016 for the contribution and @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org