You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/09 16:07:41 UTC

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1739: [CALCITE-3686] Implement bit_not function

XuQianJin-Stars opened a new pull request #1739: [CALCITE-3686] Implement bit_not function
URL: https://github.com/apache/calcite/pull/1739
 
 
   As illustrated in [CALCITE-3686](https://issues.apache.org/jira/browse/CALCITE-3686)
   select bit_not(3);
   +------------+
   | EXPR$0       |
   +------------+
   | -4                 |
   +------------+
   (1 row)
   
   !ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] hsyuan commented on issue #1739: [CALCITE-3686] Implement bit_not function

Posted by GitBox <gi...@apache.org>.
hsyuan commented on issue #1739: [CALCITE-3686] Implement bit_not function
URL: https://github.com/apache/calcite/pull/1739#issuecomment-572743144
 
 
   commented in JIRA

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function
URL: https://github.com/apache/calcite/pull/1739#discussion_r366153584
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
 ##########
 @@ -1072,6 +1072,12 @@ public static long bitAnd(long b0, long b1) {
     return b0 & b1;
   }
 
+  // ~
 
 Review comment:
   > supported in Parser
   
   `~` Not supported in Parser.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] amaliujia commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function

Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function
URL: https://github.com/apache/calcite/pull/1739#discussion_r366039048
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
 ##########
 @@ -1072,6 +1072,12 @@ public static long bitAnd(long b0, long b1) {
     return b0 & b1;
   }
 
+  // ~
 
 Review comment:
   is `~` supported in Parser, or is this `~` just a comment without indicating that parser supports `~`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services