You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "mehri92 (via GitHub)" <gi...@apache.org> on 2025/02/12 10:08:38 UTC
[PR] refactor(demo): navigation [myfaces-tobago]
mehri92 opened a new pull request, #6019:
URL: https://github.com/apache/myfaces-tobago/pull/6019
Top Navigation fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(demo): navigation [myfaces-tobago]
Posted by "henningn (via GitHub)" <gi...@apache.org>.
henningn commented on PR #6019:
URL: https://github.com/apache/myfaces-tobago/pull/6019#issuecomment-2717011494
Closed in favor of: https://github.com/apache/myfaces-tobago/pull/6163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(demo): navigation [myfaces-tobago]
Posted by "henningn (via GitHub)" <gi...@apache.org>.
henningn closed pull request #6019: refactor(demo): navigation
URL: https://github.com/apache/myfaces-tobago/pull/6019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(demo): navigation [myfaces-tobago]
Posted by "henningn (via GitHub)" <gi...@apache.org>.
henningn commented on code in PR #6019:
URL: https://github.com/apache/myfaces-tobago/pull/6019#discussion_r1952510724
##########
tobago-example/tobago-example-demo/src/main/webapp/menu.xhtml:
##########
@@ -115,7 +114,8 @@
<tc:link outcome="/content/000-intro/96-logging-info/Logging_Info.xhtml" immediate="true" label="Logging Info"
disabled="#{! serverInfo.enabled}"/>
<tc:separator/>
- <tc:link link="http://myfaces.apache.org/tobago" label="Tobago Home"/>
+ <tc:link link="http://myfaces.apache.org/tobago" label="Tobago Project" image="bi-box-arrow-up-right"/>
Review Comment:
This link doesn't work. The correct one is: https://myfaces.apache.org/#/tobago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org